From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 060BE27AE2 for ; Thu, 21 Feb 2019 08:00:59 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b-o7hc1cOU08 for ; Thu, 21 Feb 2019 08:00:58 -0500 (EST) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AF9F320AD9 for ; Thu, 21 Feb 2019 08:00:58 -0500 (EST) From: imeevma@tarantool.org Subject: [tarantool-patches] [PATCH v6 7/7] sql: remove test gh-3733-pragma.test.lua Date: Thu, 21 Feb 2019 16:00:56 +0300 Message-Id: In-Reply-To: References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: v.shpilevoy@tarantool.org Cc: tarantool-patches@freelists.org --- test/sql-tap/gh-3733-pragma.test.lua | 166 ------------------------------- test/sql-tap/pragma.test.lua | 186 ++++++++++++++++++++++++++++++++++- 2 files changed, 182 insertions(+), 170 deletions(-) delete mode 100755 test/sql-tap/gh-3733-pragma.test.lua diff --git a/test/sql-tap/gh-3733-pragma.test.lua b/test/sql-tap/gh-3733-pragma.test.lua deleted file mode 100755 index 0f856aa..0000000 --- a/test/sql-tap/gh-3733-pragma.test.lua +++ /dev/null @@ -1,166 +0,0 @@ -#!/usr/bin/env tarantool -test = require("sqltester") - -test:plan(16) - ---- ---- Prerequisites ---- -test:do_execsql_test( - "pragma-0.1", - [[ - DROP TABLE IF EXISTS gh3733; - CREATE TABLE gh3733(id INT primary key, f float); - INSERT INTO gh3733 VALUES(1, 0.1), (2, 0.2), (3, 0.3); - CREATE INDEX IDX ON GH3733 (id); - ]], { - -}) - ---- ---- pragma query_only is not supported ---- -test:do_catchsql_test( - "pragma-1.1", - [[ - pragma query_only; - ]], { - 1, "Pragma 'QUERY_ONLY' does not exist" -}) - ---- ---- pragma read_uncommitted is not supported ---- -test:do_catchsql_test( - "pragma-2.1", - [[ - pragma read_uncommitted; - ]], { - 1, "Pragma 'READ_UNCOMMITTED' does not exist" -}) - ---- ---- pragma index_list returns three columns in a row ---- -test:do_execsql_test( - "pragma-3.1", - [[ - pragma index_list(gh3733) - ]], { - -- - 0, 'pk_unnamed_GH3733_1', 1, 1, 'IDX', 0 - -- -}) - ---- ---- pragma index_list returns an empty tuple for unknown table ---- -test:do_execsql_test( - "pragma-4.1", - [[ - pragma index_list(fufel); - ]], { - -- - -- -}) - ---- ---- pragma index_info returns an empty tuple for unknown index ---- -test:do_execsql_test( - "pragma-5.1", - [[ - pragma index_info(gh3733.IDX) - ]], { - -- - 0, 0, 'ID', 0, 'BINARY', 'integer' - -- -}) - -test:do_execsql_test( - "pragma-5.2", - [[ - pragma index_info(no_table); - ]], { - -- - -- -}) - -test:do_execsql_test( - "pragma-5.3", - [[ - pragma index_info(wrong_table.IDX); - ]], { - -- - -- -}) - -test:do_execsql_test( - "pragma-5.4", - [[ - pragma index_info(gh3733.wrong_index); - ]], { - -- - -- -}) - ---- ---- pragma sql_default_engine accepts string values and rejects IDs ---- -test:do_catchsql_test( - "pragma-7.1", - [[ - pragma sql_default_engine(the_engine); - ]], { - 1, "Illegal parameters, string value is expected" -}) -test:do_catchsql_test( - "pragma-7.2", - [[ - pragma sql_default_engine(THE_ENGINE); - ]], { - 1, "Illegal parameters, string value is expected" -}) -test:do_catchsql_test( - "pragma-7.3", - [[ - pragma sql_default_engine("THE_ENGINE"); - ]], { - 1, "Illegal parameters, string value is expected" -}) - -test:do_catchsql_test( - "pragma-7.4", - [[ - pragma sql_default_engine('THE_ENGINE'); - ]], { - 1, "Space engine 'THE_ENGINE' does not exist" -}) - -test:do_catchsql_test( - "pragma-7.5", - [[ - pragma sql_default_engine(memtx); - ]], { - 1, "Illegal parameters, string value is expected" -}) - -test:do_catchsql_test( - "pragma-7.6", - [[ - pragma sql_default_engine("memtx"); - ]], { - 1, "Illegal parameters, string value is expected" -}) - -test:do_execsql_test( - "pragma-7.7", - [[ - pragma sql_default_engine('memtx'); - ]], { - -- - - -- -}) - -test:finish_test() diff --git a/test/sql-tap/pragma.test.lua b/test/sql-tap/pragma.test.lua index 935cb96..975a0e9 100755 --- a/test/sql-tap/pragma.test.lua +++ b/test/sql-tap/pragma.test.lua @@ -1,7 +1,7 @@ #!/usr/bin/env tarantool test = require("sqltester") -test:plan(9) +test:plan(24) test:do_catchsql_test( "pragma-1.3", @@ -67,7 +67,7 @@ test:do_execsql_test( ]], { -- 'vinyl' - -- + -- }) test:do_execsql_test( @@ -78,7 +78,7 @@ test:do_execsql_test( ]], { -- 'memtx' - -- + -- }) -- Check that "PRAGMA case_sensitive_like" returns its status @@ -94,7 +94,185 @@ test:do_test( end, -- 1 - -- + -- ) +-- +-- gh-3733: remove useless or obsolete pragmas +-- + +--- +--- Prerequisites +--- +test:execsql( + [[ + DROP TABLE IF EXISTS gh3733; + CREATE TABLE gh3733(id INT primary key, f float); + INSERT INTO gh3733 VALUES(1, 0.1), (2, 0.2), (3, 0.3); + CREATE INDEX IDX ON GH3733 (id); + ]]) + +--- +--- pragma query_only is not supported +--- +test:do_catchsql_test( + "pragma-4.1", + [[ + pragma query_only; + ]], { + -- + 1, "Pragma 'QUERY_ONLY' does not exist" + -- +}) + +--- +--- pragma read_uncommitted is not supported +--- +test:do_catchsql_test( + "pragma-5.1", + [[ + pragma read_uncommitted; + ]], { + -- + 1, "Pragma 'READ_UNCOMMITTED' does not exist" + -- +}) + +--- +--- pragma index_list returns three columns in a row +--- +test:do_execsql_test( + "pragma-6.1", + [[ + pragma index_list(gh3733) + ]], { + -- + 0, 'pk_unnamed_GH3733_1', 1, 1, 'IDX', 0 + -- +}) + +--- +--- pragma index_list returns an empty tuple for unknown table +--- +test:do_execsql_test( + "pragma-7.1", + [[ + pragma index_list(fufel); + ]], { + -- + -- +}) + +--- +--- pragma index_info returns an empty tuple for unknown index +--- +test:do_execsql_test( + "pragma-8.1", + [[ + pragma index_info(gh3733.IDX) + ]], { + -- + 0, 0, 'ID', 0, 'BINARY', 'integer' + -- +}) + +test:do_execsql_test( + "pragma-8.2", + [[ + pragma index_info(no_table); + ]], { + -- + -- +}) + +test:do_execsql_test( + "pragma-8.3", + [[ + pragma index_info(wrong_table.IDX); + ]], { + -- + -- +}) + +test:do_execsql_test( + "pragma-8.4", + [[ + pragma index_info(gh3733.wrong_index); + ]], { + -- + -- +}) + +--- +--- pragma sql_default_engine accepts string values and rejects IDs +--- +test:do_catchsql_test( + "pragma-9.1", + [[ + pragma sql_default_engine(the_engine); + ]], { + -- + 1, "Illegal parameters, string value is expected" + -- +}) + +test:do_catchsql_test( + "pragma-9.2", + [[ + pragma sql_default_engine(THE_ENGINE); + ]], { + -- + 1, "Illegal parameters, string value is expected" + -- +}) + +test:do_catchsql_test( + "pragma-9.3", + [[ + pragma sql_default_engine("THE_ENGINE"); + ]], { + -- + 1, "Illegal parameters, string value is expected" + -- +}) + +test:do_catchsql_test( + "pragma-9.4", + [[ + pragma sql_default_engine('THE_ENGINE'); + ]], { + -- + 1, "Space engine 'THE_ENGINE' does not exist" + -- +}) + +test:do_catchsql_test( + "pragma-9.5", + [[ + pragma sql_default_engine(memtx); + ]], { + -- + 1, "Illegal parameters, string value is expected" + -- +}) + +test:do_catchsql_test( + "pragma-9.6", + [[ + pragma sql_default_engine("memtx"); + ]], { + -- + 1, "Illegal parameters, string value is expected" + -- +}) + +test:do_execsql_test( + "pragma-9.7", + [[ + pragma sql_default_engine('memtx'); + ]], { + -- + -- +}) + test:finish_test() -- 2.7.4