From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 15F384696C3 for ; Mon, 10 Feb 2020 22:37:00 +0300 (MSK) References: <20200210063144.lcsc5vbe5jus7jt4@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 10 Feb 2020 20:36:57 +0100 MIME-Version: 1.0 In-Reply-To: <20200210063144.lcsc5vbe5jus7jt4@tarantool.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Tarantool-patches] [PATCH 1/1] fio: close unused descriptors automatically List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Hi! On 10/02/2020 07:31, Kirill Yukhin wrote: > Hello, > > On 09 фев 18:37, Vladislav Shpilevoy wrote: >> test/app/fio.result | 93 +++++++++++++++++++++++++++++++++++++++++++ >> test/app/fio.test.lua | 58 +++++++++++++++++++++++++++ > > Could you please put the test into separate file? It contradicts with SOP. " We do not create a separate file for each feature - that would lead to a huge number of files. For a bug fix, please create a separate file with autonomous test case in a correponding test suite. Name should follow this format: /gh-XXX-two-three-word-title " This is not a bugfix. It is a feature. Auto GC of FIO was never documented anywhere, so this was not a bug. And according to SOP it should not be in a separate file. But ok, I moved it. > -- > Regards, Kirill Yukhin >