From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BF29C469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 15:22:14 +0300 (MSK)
References: <20200512135052.221379-1-gorcunov@gmail.com>
 <20200512135052.221379-8-gorcunov@gmail.com>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <d5990c80-70dc-b8f9-b158-3da0811fabaf@tarantool.org>
Date: Mon, 18 May 2020 15:22:13 +0300
MIME-Version: 1.0
In-Reply-To: <20200512135052.221379-8-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 7/7] test: extend console lua test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi. Thanks for your patch! LGTM.

On 12/05/2020 16:50, Cyrill Gorcunov wrote:
> To make sure ULL constants are not broken.
> 
> Part-of #4682
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   test/app-tap/console_lua.test.lua | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/test/app-tap/console_lua.test.lua b/test/app-tap/console_lua.test.lua
> index 8bb6eb0b3..dbfc3da11 100755
> --- a/test/app-tap/console_lua.test.lua
> +++ b/test/app-tap/console_lua.test.lua
> @@ -116,11 +116,26 @@ local cases = {
>           opts        = {block = false},
>           input       = '1, nil, box.NULL, nil',
>           expected    = '1, nil, box.NULL, nil',
> +    }, {
> +        name        = 'leading nils, box.NULL, line mode',
> +        opts        = {block = false},
> +        input       = 'nil, 1, nil, box.NULL, nil',
> +        expected    = 'nil, 1, nil, box.NULL, nil',
>       }, {
>           name        = 'trailing nils, box.NULL, block mode',
>           opts        = {block = true},
>           input       = '1, nil, box.NULL, nil',
>           expected    = '1, nil, box.NULL, nil',
> +    }, {
> +        name        = 'ULL constants, multireturn',
> +        opts        = {block = false},
> +        input       = '-1ULL, -2ULL, 1ULL, 2ULL',
> +        expected    = '18446744073709551615, 18446744073709551614, 1, 2',
> +    }, {
> +        name        = 'ULL key',
> +        opts        = {block = false},
> +        input       = '{[-1ULL] = 1}',
> +        expected    = '{[18446744073709551615] = 1}',
>       }, {
>           name        = 'empty output',
>           input       = '\\set output',
>