From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arkholga@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8DB98445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Jul 2020 09:38:28 +0300 (MSK)
References: <20200629121118.21596-1-arkholga@tarantool.org>
 <20200629121118.21596-2-arkholga@tarantool.org>
 <20200701213447.GE5559@tarantool.org>
 <16d471e3-d578-7b12-6a4f-08814a2f1b64@tarantool.org>
 <20200709010804.7kejojfasvu7o7oj@tkn_work_nb>
 <d44439cb-187e-ff28-6c9f-46c29952ac54@tarantool.org>
 <20200715144023.pll42732ijjw6obo@tkn_work_nb>
 <20200716175618.GN5559@tarantool.org>
 <1d010980-646d-3c73-bef7-1009fff6609c@tarantool.org>
 <20200716210443.GQ5559@tarantool.org>
From: Olga Arkhangelskaia <arkholga@tarantool.org>
Message-ID: <d5738e82-499c-4d8a-2767-f0aab58dcde2@tarantool.org>
Date: Fri, 17 Jul 2020 09:38:25 +0300
MIME-Version: 1.0
In-Reply-To: <20200716210443.GQ5559@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 1/1] box: fixed box.info:memory()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>


17.07.2020 0:04, Igor Munkin пишет:
> Olya,
>
> Thanks for the fixes! I checked the upstream. The patch LGTM except the
> tiny nit.
>
>
> Sasha, please proceed with the patch.
>
> On 16.07.20, Olga Arkhangelskaia wrote:
>
> <snipped>
>
>> When box.info:memory is called, it has box.info table as a first
> Typo: s/a first/the first/.
Fixed
>
>> argument (seehttps://www.lua.org/manual/5.1/manual.html#2.8). While
>> printing the table, lbox_info_memory_call adds box.info.memory's fields
>> to the box.info table. To avoid this effect and return just
>> box.info.memory we put an empty table on the Lua stack at the beginning
>> of the lbox_info_memory_call function. Instead adding fields to box.info
>> table lbox_info_memory_call fills that empty table.
> <snipped>
>