From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ED7AA469710 for ; Sat, 21 Nov 2020 17:41:13 +0300 (MSK) References: <41492964d52aa46391a621e640f1ffc83bf5a0b0.1605629206.git.sergeyb@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Sat, 21 Nov 2020 15:41:11 +0100 MIME-Version: 1.0 In-Reply-To: <41492964d52aa46391a621e640f1ffc83bf5a0b0.1605629206.git.sergeyb@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 1/4] replication: run clear_synchro_queue() with unconfigured box List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Hi! Thanks for the patch! >From the commit title it seems like you introduced a feature to run the function with non-configured box. Please, change 'run' to 'test', would be better already. Also for qsync we usually write title 'qsync: ...', not just 'replication: ...'. Or in your case it could be 'test: ...', but up to you. The same for the other commits. The patch itself is good.