From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A72BC23C0E for ; Mon, 2 Jul 2018 07:23:07 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G6P4Orx51OGS for ; Mon, 2 Jul 2018 07:23:07 -0400 (EDT) Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6681123BBB for ; Mon, 2 Jul 2018 07:23:07 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless code from os_unix.c References: <443107fc62c650cea3007bf46975e5965518b02a.1530199154.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 2 Jul 2018 14:22:40 +0300 MIME-Version: 1.0 In-Reply-To: <443107fc62c650cea3007bf46975e5965518b02a.1530199154.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Hello. Thanks for the patch! See 2 comments below. On 28/06/2018 18:21, Kirill Shcherbatov wrote: > Resolves #3284. > --- > https://github.com/tarantool/tarantool/tree/kshch/gh-3284-no-os-unix > https://github.com/tarantool/tarantool/issues/3284 > src/box/sql/os.c | 168 -- > src/box/sql/os_unix.c | 6195 ++++++++++------------------------------------- > src/box/sql/sqliteInt.h | 1 - > 3 files changed, 1342 insertions(+), 5022 deletions(-) > > diff --git a/src/box/sql/os.c b/src/box/sql/os.c > index 38d3585..5a04edb 100644 > --- a/src/box/sql/os.c > +++ b/src/box/sql/os.c > @@ -123,123 +123,12 @@ sqlite3OsWrite(sqlite3_file * id, const void *pBuf, int amt, i64 offset) > return id->pMethods->xWrite(id, pBuf, amt, offset); > } > > -int > -sqlite3OsTruncate(sqlite3_file * id, i64 size) > -{ > - return id->pMethods->xTruncate(id, size); > -} 1. These functions still are visible in grep results. 2. And much more functions and constants are either unused, or just declared, but has no implementation. Please, complete the patch. I have pushed some of removals on the branch as a separate commit. Please, squash and finalize. > - > -int > -sqlite3OsSync(sqlite3_file * id, int flags) > -{ > - DO_OS_MALLOC_TEST(id); > - return id->pMethods->xSync(id, flags); > -} > -