From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E68CD9E225B; Mon, 4 Mar 2024 16:32:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E68CD9E225B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1709559177; bh=IS/MIg9brlok2efFjcOoZx7FxeVQhl5DWiPSH9LbCrk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=N6CHeoFBqgUwDbd1JY6M35zD1WbfdsvUWw/T072IBXe2qGbbjdDnydhOYEpKfTm0Q +JzDSGYz89Mu3Q5kyCYUHEVgxFZdZu3Q8reU+gtz8n9tAdBQzn2f3YY3FNacCagY01 OxtH4ixJbkTJvs/Z7xPAsPbdmCBMQk1inEOgXOAY= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5551C516FC8 for ; Mon, 4 Mar 2024 16:32:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5551C516FC8 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1rh8R4-00000003SPa-1aeM; Mon, 04 Mar 2024 16:32:54 +0300 Message-ID: Date: Mon, 4 Mar 2024 16:32:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org References: <20240301132127.136533-1-m.kokryashkin@tarantool.org> Content-Language: en-US In-Reply-To: <20240301132127.136533-1-m.kokryashkin@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597DA4A6782E56D87B648E017E9626570F41182A05F538085040FD50612FA1ADB6B8A6D5EE0DB6E1EC8DACFB80CCD031C9BE0700452A40C063939EED9D81CC76A58E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB6A86BDF2D5A895EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D07BBD2EBFB7BF888638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CEBCEC1AE679A7F1B4627379ABF177DBE11C53B64EA4C28DCC7F00164DA146DAFE8445B8C89999728AA50765F79006370BDB19F53EE528DD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8989FD0BDF65E50FBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C632EDEA9CD5989A39735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C31DA0D137B259B101BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C332C16DEEF884694935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A54ECB611B08E4F16D5002B1117B3ED6965D5C256A993CB94C1BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEADA91A6E18C88C5E2F X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFF7B436CD81F4EDD483C5BDE2FA65052BAB963467724F650B3A2113E50309EAD260849098BFF6585AA2A143A52978B9DDACA2E2BF49C4A8B5F84810344F979F1A1D2E5C61C51040FE5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+F5rnR9AEqnjFyYsim0oSw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769A359BD0D4C16C98DA6D5EE0DB6E1EC8DACFB80CCD031C9BEB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] Throw any errors before stack changes in trace stitching. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max thanks for the patch! LGTM with a minor comment On 3/1/24 16:21, Maxim Kokryashkin wrote: > From: Mike Pall > > Thanks to doujiang24. > > (cherry-picked from commit 3f9389edc6cdf3f78a6896d550c236860aed62b2) > > The Lua stack is changed in the `recff_stitch`, so if the trace > is aborted, for example, when the `maxsnap` is reached, and an > error is thrown from there, the execution continues with an > unbalanced stack. > > This patch adds a check for snapshot overflow to the > `recff_stitch` to overcome the issue for the `LJ_TRERR_SNAPOV` > case, but other cases remain unresolved and should be fixed in > other series. For a detailed description of the remaining cases, > see the issue[1]. > > [1]: https://github.com/LuaJIT/LuaJIT/issues/1166 Probably it is better to remove a link to the issue to avoid spam in GH notifications. Or replace it with "LJ#1166".