From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1321945C304
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 15 Dec 2020 16:00:53 +0300 (MSK)
References: <cover.1607675470.git.sergeyb@tarantool.org>
 <64faf8a1d1571ca757aa1cdb3e5f1f3aadaa4088.1607675470.git.sergeyb@tarantool.org>
 <37684f41-344d-687a-bdee-7aaf322a43d1@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <d42ece05-998d-7f7a-12e8-9a5d9ce5f600@tarantool.org>
Date: Tue, 15 Dec 2020 16:00:52 +0300
MIME-Version: 1.0
In-Reply-To: <37684f41-344d-687a-bdee-7aaf322a43d1@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 4/4] test: remove dead code in
 Python tests end extra newline
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, imun@tarantool.org
Cc: alexander.turenko@tarantool.org


On 15.12.2020 15:51, Leonid Vasiliev wrote:
> Hi! Thank you for the patch.
> Generally LGTM.
> Look one commit below:
>
> On 11.12.2020 11:42, Sergey Bronnikov via Tarantool-patches wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>> <snipped>
>> index b1442c520..a40133ef2 100644
>> --- a/test/xlog-py/dup_key.test.py
>> +++ b/test/xlog-py/dup_key.test.py
>> @@ -3,11 +3,6 @@ from __future__ import print_function
>>   import os
>>   import yaml
>>   -#print """
>> -#A test case for https://bugs.launchpad.net/tarantool/+bug/1052018
>> -#panic_on_wal_error doesn't work for duplicate key errors
>> -#"""
>
> Seems like
> ```
> #A test case for https://bugs.launchpad.net/tarantool/+bug/1052018
> #panic_on_wal_error doesn't work for duplicate key errors
> ```
> can be left as a comment to the test (without `print`).

Agree.

--- a/test/xlog-py/dup_key.test.py
+++ b/test/xlog-py/dup_key.test.py
@@ -3,6 +3,9 @@ from __future__ import print_function
  import os
  import yaml

+# A test case for https://bugs.launchpad.net/tarantool/+bug/1052018
+# panic_on_wal_error doesn't work for duplicate key errors
+
  server.stop()
  server.deploy()

>
>> -
>>   server.stop()
>>   server.deploy()
>>   diff --git a/test/xlog-py/lsn_gap.test.py 
>> b/test/xlog-py/lsn_gap.test.py
>> index 8da6166a2..b80b97146 100644
>> --- a/test/xlog-py/lsn_gap.test.py
>> +++ b/test/xlog-py/lsn_gap.test.py
>> @@ -38,4 +38,3 @@ print("")
>>     # missing tuple from removed xlog
>>   server.admin("box.space.test:select{}")
>> -
>>