From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BE6A16C7D2; Thu, 11 Feb 2021 01:33:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BE6A16C7D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612996430; bh=ZzL8nX8nbeFQD515Ly7tORZLGkuErpPCHt3ncgTHrEE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=nxSowktXi9D0QrDbdObGliuTrbiOIY7G2qz2rJv/MXMdz6dZ63QscqnxyhFuSAIWu 42n0qGtsYgfL0ooyUCN02nXmdmjVVZamFDrT5/tp8E/WcAgbZ7eFJArMHZHB7hmCPc loawSzhGStyqcGg7MOw0nHEzSDhB18iwQ/0N8NnM= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E13A66C7D5 for ; Thu, 11 Feb 2021 01:33:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E13A66C7D5 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1l9y2z-000711-Ri; Thu, 11 Feb 2021 01:33:22 +0300 To: Oleg Babin , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <4436bd47-7656-340d-31c3-de4146ab6aa6@tarantool.org> Message-ID: Date: Wed, 10 Feb 2021 23:33:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <4436bd47-7656-340d-31c3-de4146ab6aa6@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9C4647521586BE7E6324520D2A088600D8182A05F538085040995FE046125DF283B5F2873F904678448A592DA241F82174879ECB7D3D9EB1E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE779AAD18609327F83EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE92FB8C11ED3D88638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC5ED48DDBF877A970E0083E64D1BE78534A90F83A38A6DCE7389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC3241B8C6B78F28F975ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735789C969B8F27C422C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5179EDFAADDE56765A4F6CA68851F0C40D184B5C275D03121D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349320586B19AD2C72B8AF5763EC1DDC9ACCF8838ED8626E7337B17BA02D1B5A8CFF4D09231A696E8B1D7E09C32AA3244CD7407E5C3E5BBC6292E0602C54108D8639C99C45E8D137E9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmMmQ+JvDeDHKZx2I5Katug== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822DF92C5E8C108347E6B7A56C025A5000D3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/9] test: introduce a helper to wait for bucket GC X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! On 10.02.2021 09:57, Oleg Babin wrote: > Hi! Thanks for your patch! LGTM but I have one question. > > Maybe it's reasonable to add some timeout in this function? > > AFAIK test-run terminates tests after 120 seconds of inactivity it seems too long for such simple case. > > But anyway it's up to you. test_run:wait_cond() has default timeout 1 minute. I decided it is fine.