From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E9BCD28980 for ; Mon, 13 Aug 2018 16:24:34 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l9gtr6tl3I60 for ; Mon, 13 Aug 2018 16:24:34 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A571B289E2 for ; Mon, 13 Aug 2018 16:24:34 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 02/10] sql: remove string of fields collation from Table References: From: Vladislav Shpilevoy Message-ID: Date: Mon, 13 Aug 2018 23:24:32 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! I have pushed my review fixes in a separate commit. Comment about my fix: you do not need to set oomfault from sqlite malloc wrappers - it is already done inside. On 12/08/2018 17:12, Nikita Pettik wrote: > Part of #3561 > --- > src/box/sql/build.c | 1 - > src/box/sql/insert.c | 71 +++++++++++-------------------------------------- > src/box/sql/sqliteInt.h | 14 +++++++--- > src/box/sql/update.c | 2 +- > 4 files changed, 28 insertions(+), 60 deletions(-) >