From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BE3EA6EC40; Sun, 4 Jul 2021 16:09:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BE3EA6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625404150; bh=SOQ0APSj+hk51t3EjObgOnod4ubV5K7b7z2qyt7bBBI=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=i1KJB2O5znhPaSaEfZNhgDddn7GTnn4gmo4AhkiGqiJyD7H7gKcfvabKA40urpGDd Nz/BsK1TddOMxZjHPTFwoReOT/GjLHKOOR0u80/WvflrpkTogG550qdPZ+9AL718aZ w+xdNI5msHPiwHEI1PmeL6FrlqOkl1rGY2vLboac= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DE9506EC40 for ; Sun, 4 Jul 2021 16:09:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DE9506EC40 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m01rw-0001Kd-V5; Sun, 04 Jul 2021 16:09:09 +0300 To: Alexander Turenko , Cyrill Gorcunov , Roman Khabibov Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Sun, 4 Jul 2021 15:09:07 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FBE6C6848F3EB6EB89AE0756428E32ECE9182A05F538085040B3B21502B1FB27420C2A7FAB186A3FBE8554BDF4B80E3BB43D5D1D04BCFAF1C8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370F98874192B1BA168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8117E0E7FF8E4F3F6CD543FA8A2CD4F9E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831BBCB891EED09B37AAC1B55117025DB7A X-C1DE0DAB: 0D63561A33F958A51CD8E5796B266B49BCE08EB420A6590333973890D34C07EFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75342909995EBBA6E4410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344F2126FF337FA651B2BBAAD09E64E6DB61C9446A68FB671C6720687A3BC8A44CAED343F7B8148CBC1D7E09C32AA3244CF8EF41C28655797E7DABB9B9E020CE0105AB220A9D022EBC927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5fH2RN9TpJnifHak3VYdPg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DC51D5F5891D37A240123EA04234A48163841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/4] RFC: Isolate serializer helpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patchset! On 23.06.2021 21:12, Alexander Turenko via Tarantool-patches wrote: > Moved the serializer helpers into its own compilation unit, add some > comments and a basic test: everything is just to simplify diving into > this code. > > Guys, please, look, whether it seems useful enough to include into > tarantool's mainline? Should we name it serializer.[ch] or > somehow like serializer_helpers.[ch]? > > Part of https://github.com/tarantool/tarantool/issues/3228 Are you sure you need to fix it? It looks like a regular leg shooting. It might be simple to detect in the case described by Mons, but what if the recursion is not so easily visible? setmetatable({},{ __serialize = function(a) return {{{{a}}}} end }) You would need to use recursion detection algorithms like the one we used to ask on interviews. And I am not sure it is worth it if it can't be done in a simple way.