From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org, skaplun@tarantool.org,
m.kokryashkin@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled.
Date: Fri, 29 Dec 2023 16:40:23 +0300 [thread overview]
Message-ID: <d29a7b9b-03e5-499b-b9fe-96fd823bcb5b@tarantool.org> (raw)
In-Reply-To: <20231211112657.19060-1-max.kokryashkin@gmail.com>
Hello, Max!
thanks for the patch! LGTM with a minor comment
On 12/11/23 14:26, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
>
> (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16)
>
> Prior to this patch, the LuaJIT build with the
> `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of
> linker relocation errors related to dwarf-specific code. This
probably it is worth adding an error message produced by linker.
Feel free to ignore.
<snipped>
next prev parent reply other threads:[~2023-12-29 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 11:26 Maksim Kokryashkin via Tarantool-patches
2023-12-12 9:38 ` Sergey Kaplun via Tarantool-patches
2023-12-29 13:40 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-01-09 14:18 ` Maxim Kokryashkin via Tarantool-patches
2024-01-16 9:47 ` Sergey Bronnikov via Tarantool-patches
2024-02-15 13:41 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d29a7b9b-03e5-499b-b9fe-96fd823bcb5b@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox