From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D847324466 for ; Thu, 24 Jan 2019 09:53:24 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1T6Nyn5p04zg for ; Thu, 24 Jan 2019 09:53:24 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8F64823440 for ; Thu, 24 Jan 2019 09:53:24 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v4 5/6] sql: 'PRAGMA' result in YAML format References: <4424957D-71D2-4C31-A288-42E22462055B@tarantool.org> From: Imeev Mergen Message-ID: Date: Thu, 24 Jan 2019 17:53:22 +0300 MIME-Version: 1.0 In-Reply-To: <4424957D-71D2-4C31-A288-42E22462055B@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" , tarantool-patches@freelists.org Hi! Thank you for review. Changed commit-message. On 1/20/19 3:19 AM, n.pettik wrote: >> New version: >> >> commit a3e6e457680e9aef5af78ca7a92f1572fcfbdef4 >> Author: Mergen Imeev >> Date: Thu Dec 13 21:07:31 2018 +0300 >> >> sql: 'PRAGMA' result in YAML format > Commit's subject would look better with verb. > > For instance: > > sql: get results of PRAGMA statement in YAML format > > Or sort of. > > The rest is OK in this patch-set, so LGTM. > Fixed. New commit-message: commit 1a7fd53719a4790845c68f815a4f1a9f4f84b97a Author: Mergen Imeev Date:   Thu Dec 13 21:07:31 2018 +0300     sql: get results of PRAGMA statement in YAML format     Currently box.sql.execute ('PRAGMA') returns nothing, but prints     list of pragmas and their statuses to stdout. Such strategy is     considered to be wrong since output of this command would be     unavailable for users who redirect stdout, use net box connection     etc. This patch makes the command to return result as the rest of     SQL commands. The result contains only FLAG-type pragmas and their     statuses in YAML format.