From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 941292215D for ; Mon, 21 May 2018 05:48:01 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 58mgKPUXz6s1 for ; Mon, 21 May 2018 05:48:01 -0400 (EDT) Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DA91522104 for ; Mon, 21 May 2018 05:48:00 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] sql: refactor SQL delete to allow Lua spaces References: <87358913270ee98c98bc276209289d6b7ac496b6.1526650490.git.kyukhin@tarantool.org> <946fafd7-9e8a-0263-ecaa-02df83c82223@tarantool.org> <20180521082048.2n5vzzsgxcb7fyss@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 21 May 2018 12:47:56 +0300 MIME-Version: 1.0 In-Reply-To: <20180521082048.2n5vzzsgxcb7fyss@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Yukhin Cc: tarantool-patches@freelists.org Hello. Thanks for the fixes! > > diff --git a/src/box/sql/build.c b/src/box/sql/build.c > index df75186..68f81e8 100644 > --- a/src/box/sql/build.c > +++ b/src/box/sql/build.c > @@ -2108,107 +2108,97 @@ sqlite3CreateView(Parse * pParse, /* The parsing context */ > } > #endif /* SQLITE_OMIT_VIEW */ > > -#if !defined(SQLITE_OMIT_VIEW) > -/* > - * The Table structure pTable is really a VIEW. Fill in the names of > - * the columns of the view in the pTable structure. Return the number > - * of errors. If an error is seen leave an error message in pParse->zErrMsg. > - */ > -int > -sqlite3ViewGetColumnNames(Parse * pParse, Table * pTable) > +bool In Tarantool code style we do not return boolean on non-check functions. 0 or -1, please. The rest of patch is ok.