From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CCC196BD29; Tue, 13 Apr 2021 02:36:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CCC196BD29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618270608; bh=4H+hNytTFQF5DI8ddNVGSeFNYHeZVPj43uuD5UDKwso=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qniEI/4Cs75xl6qZGCD9i62tD5PuXe08ZGdLr3R5A0KgVwwSWwH7fGjfJ5NG22ZJ+ TCckrM0dBnwaJuu+Ike9O6yVlSAqB6xFlr4l1azKXKvgmiOW66llBeD92OQUFl0RQ8 RaoOawqjUpp6RiIj1U1t4HtZhhr9+0VekTMfnMwU= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BF6846BD23 for ; Tue, 13 Apr 2021 02:36:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF6846BD23 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lW66o-00050z-1x; Tue, 13 Apr 2021 02:36:46 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <26b61648509b08b4cde3307015d398372cdd20f3.1617984948.git.imeevma@gmail.com> Message-ID: Date: Tue, 13 Apr 2021 01:36:45 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <26b61648509b08b4cde3307015d398372cdd20f3.1617984948.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979723F2FB4628545A35182A05F538085040DD473FC7BBC000E9C9847C5F9635305173E347752AE86BA17427134775A9141A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EED5D2FAB4CEB1EDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B323FE155BC226618638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2D9F1B00AB5645E802C3007FF2F18557C9414A38D98B987DBD2E47CDBA5A96583C09775C1D3CA48CF4964A708C60C975A117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE78C592797616C97AB9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7359EF166FBCB559E95C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A569EC3DACEB15B2F71BD552604DCD75CCA8936B34EF2130F5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349EC559D073CA5B68F4CBC881DB0952280C50D8498BADDD9A52046E085570C76186AFEDFAA4A658681D7E09C32AA3244CECB82D9350F26C52085EF6E4309DFAB6F26BFA4C8A6946B8FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojq8JA+pXcDukr9Zb/NafQRA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382231227D1B105FE5C4A4E542E753BDF0CF3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 32/52] sql: introduce mem_set_*() for map and array X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for working on this! > diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c > index 508b1dee3..61849cde7 100644 > --- a/src/box/sql/mem.c > +++ b/src/box/sql/mem.c > @@ -520,6 +520,75 @@ mem_set_zerobin(struct Mem *mem, int n) > mem->field_type = FIELD_TYPE_VARBINARY; > } > > +static inline void > +set_msgpack_value(struct Mem *mem, char *value, uint32_t size, int alloc_type, > + enum field_type type) > +{ > + if (alloc_type == MEM_Ephem || alloc_type == MEM_Static) > + set_bin_const(mem, value, size, alloc_type); > + else > + set_bin_dynamic(mem, value, size, alloc_type); > + mem->flags |= MEM_Subtype; > + mem->subtype = SQL_SUBTYPE_MSGPACK; > + mem->field_type = type; Previously field_type wasn't set. Why did you change that?