From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2D53829277 for ; Fri, 1 Jun 2018 14:00:53 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q2C-__FOHHyv for ; Fri, 1 Jun 2018 14:00:53 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DF33729276 for ; Fri, 1 Jun 2018 14:00:52 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/3] sql: remove expressions from SQL indexes References: <787e55ddaaeeec54e870d3f493fc235fe64ffd51.1527865931.git.kyukhin@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Fri, 1 Jun 2018 21:00:50 +0300 MIME-Version: 1.0 In-Reply-To: <787e55ddaaeeec54e870d3f493fc235fe64ffd51.1527865931.git.kyukhin@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Yukhin Thanks for the patch! See 2 comments below. On 01/06/2018 18:16, Kirill Yukhin wrote: > Legacy SQL FE was able to create indexes w/ expressions. > Tarantool will employ diofferenct scheme to implement 1. diofferenct? > functional indexes, thus code handling it in SQL FE is > dead and redundant. Remove it. > > Part of #3235 2. I pushed my review fixes. Please, consider them as squash if ok. > --- > src/box/sql/build.c | 22 ++++++--------- > src/box/sql/delete.c | 3 +-- > src/box/sql/expr.c | 12 ++------- > src/box/sql/insert.c | 72 +++++++++++++++---------------------------------- > src/box/sql/sqliteInt.h | 6 ----- > src/box/sql/where.c | 27 ++----------------- > src/box/sql/wherecode.c | 13 +++------ > src/box/sql/whereexpr.c | 36 +++---------------------- > 8 files changed, 42 insertions(+), 149 deletions(-) >