From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AD0A06EC40; Tue, 6 Jul 2021 11:55:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AD0A06EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625561703; bh=P51i6j8kFjxgl079imMvBtxs6wK6FwX3pgnQP/+WArg=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=tUO0exbCKGWkhmtrCkEtf1C2Incs0JOMWctjGU/HoTETAoObfsV5rrxiH5foNwgHu OQtqaUOqRqQrXPs6IjxeBnsFFEEHQ/bPxsyILE6dwSHWTqlJHD3qjKWdwVpm3CjdFk kS6Pv14Z7SLBEYvKqAAYd3Cop0vJx/jVjGEO84aw= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6E23E6EC40 for ; Tue, 6 Jul 2021 11:55:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6E23E6EC40 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1m0gr7-0003mq-N3; Tue, 06 Jul 2021 11:55:02 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <1b0facbff8f285ec54c03a3ec68fca777f4828a3.1625177222.git.v.shpilevoy@tarantool.org> <2dc3ff07-5f6e-294f-670a-5dcc5948c839@tarantool.org> <6073e325-a77b-c5c1-8950-950f41c36ac3@tarantool.org> <7621af8d-7918-950d-4911-dec06cadb95b@tarantool.org> Message-ID: Date: Tue, 6 Jul 2021 11:55:01 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB64496B12B6C6FB871CAFB561BC326F0E182A05F538085040BD62EBA70568486930146E5C7B27A3E1C7F79DA1357B4DB018F0B881BA08324C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790B55F3E386DB9B28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D813788B7E3F724CB7A1002446B84C0055117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAB5495298CADBD05A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209647ADFADE5905B128451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B500AC0B2F9B62304D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A7DFDF579AB090EF6E0066C2D8992A16C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5358A544BEEAC4A4E05E5A097234AA29D98FE929DDB4F7CB6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75342909995EBBA6E4410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D4140D813EC137C6E488DAD8F2CD5B384D9B2B0BF746FDC899D5838FA7D2B098511BD335A59696FB1D7E09C32AA3244C0B54554F70FB04BF8EAC3B538C7EA8F46C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojotfFaHYUgbDs5KpKNGT1zQ== X-Mailru-Sender: 583F1D7ACE8F49BD07526C4546A62CBFB9ADE09451278EA1882B30E3D05B7A474E4FC7339A2C458D23E75C7104EB1B885DEE61814008E47C7013064206BFB89F93956FB04BA385BE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 6/6] router: update master using a hint from storage X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your changes. LGTM. On 05.07.2021 23:53, Vladislav Shpilevoy wrote: >>   - After changes in previous patch I think it could be better to use "master_search_wakeup" instead of master_search_fiber:wakeup() > Yes, I forgot to update this commit. Done now: > > ==================== > diff --git a/test/router/master_discovery.result b/test/router/master_discovery.result > index 8416c8f..7ebb67d 100644 > --- a/test/router/master_discovery.result > +++ b/test/router/master_discovery.result > @@ -115,7 +115,7 @@ function check_no_master_for_replicaset(rs_id) > if not master then \ > return true \ > end \ > - vshard.router.static.master_search_fiber:wakeup() \ > + vshard.router.master_search_wakeup() \ > return false \ > end > | --- > @@ -170,7 +170,7 @@ function check_master_discovery_block() > if vshard.router.internal.errinj.ERRINJ_MASTER_SEARCH_DELAY == 'in' then \ > return true \ > end \ > - vshard.router.static.master_search_fiber:wakeup() \ > + vshard.router.master_search_wakeup() \ > return false \ > end > | --- > diff --git a/test/router/master_discovery.test.lua b/test/router/master_discovery.test.lua > index 9a9e60d..6276dc9 100644 > --- a/test/router/master_discovery.test.lua > +++ b/test/router/master_discovery.test.lua > @@ -73,7 +73,7 @@ function check_no_master_for_replicaset(rs_id) > if not master then \ > return true \ > end \ > - vshard.router.static.master_search_fiber:wakeup() \ > + vshard.router.master_search_wakeup() \ > return false \ > end > > @@ -114,7 +114,7 @@ function check_master_discovery_block() > if vshard.router.internal.errinj.ERRINJ_MASTER_SEARCH_DELAY == 'in' then \ > return true \ > end \ > - vshard.router.static.master_search_fiber:wakeup() \ > + vshard.router.master_search_wakeup() \ > return false \ > end > > ==================== > >>   - Should we document somehow `update_master` method for replicaset object? Or maybe it even shouldn't be a part of public API? > Nope. It is a private method. If something is not documented on the > site, it is private. I couldn't come up with a better scheme and yet > not harm vshard's own code readability.