From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8F475445320
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 12 Jul 2020 18:32:00 +0300 (MSK)
References: <20200708114718.38910-1-roman.habibov@tarantool.org>
 <20200708114718.38910-3-roman.habibov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <d19f7068-1668-1a99-70db-78d05ee25141@tarantool.org>
Date: Sun, 12 Jul 2020 17:31:58 +0200
MIME-Version: 1.0
In-Reply-To: <20200708114718.38910-3-roman.habibov@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: clarify
 "sql_defer_foreign_keys" setting name
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

See 3 comments below.

On 08.07.2020 13:47, Roman Khabibov wrote:
> Raname "sql_defer_foreign_keys" setting to
> "sql_defer_foreign_key_changes".

1. 'Raname' -> 'Rename'.

2. I think the new name is worse. Changes are done immediately.
You can't defer them. The flag means defer the foreign key checks,
not changes. To allow temporary inconsistency if a transaction needs
it, but still check FKs when it will commit.

> Follow up #4511
> 
> @TarantoolBot document
> Title: sql_defer_foreign_keys in _space_settings

3. There is no such space '_space_settings'.

> Rename "sql_defer_foreign_keys" setting to
> "sql_defer_foreign_key_changes".