From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DA1B6289E2 for ; Mon, 13 Aug 2018 16:24:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7izOoNYPtKRX for ; Mon, 13 Aug 2018 16:24:31 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 97864289F6 for ; Mon, 13 Aug 2018 16:24:31 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 06/10] sql: completely remove support of partial indexes References: <426c951a553688d1a07139596f79512a2caa6c28.1534001739.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 13 Aug 2018 23:24:29 +0300 MIME-Version: 1.0 In-Reply-To: <426c951a553688d1a07139596f79512a2caa6c28.1534001739.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! I have pushed my review fixes in a separate commit. Please, investigate also is it possible to remove pPartial variable from constructAutomaticIndex? It would allow to remove sql_resolve_part_idx_label alongside. On 12/08/2018 17:13, Nikita Pettik wrote: > We banned opportunity to create partial indexes long ago, but internal > routine implementing this feature still remains. This patch completely > removes it. > > Part of #3561 > --- > src/box/sql/build.c | 23 ++++++----------------- > src/box/sql/delete.c | 17 +++-------------- > src/box/sql/insert.c | 12 ------------ > src/box/sql/parse.y | 6 +++--- > src/box/sql/pragma.c | 5 +---- > src/box/sql/sqliteInt.h | 7 ++----- > src/box/sql/update.c | 2 +- > src/box/sql/where.c | 31 ------------------------------- > 8 files changed, 16 insertions(+), 87 deletions(-) >