From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3E7F128829 for ; Thu, 29 Aug 2019 16:43:12 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k2BQTFpJ_A_O for ; Thu, 29 Aug 2019 16:43:12 -0400 (EDT) Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EBD9B287CF for ; Thu, 29 Aug 2019 16:43:11 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/8] port: increase padding of struct port References: <7e354aa295b6dbac92baa4ec5f4bc39f4f4d0053.1566907520.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 29 Aug 2019 22:46:25 +0200 MIME-Version: 1.0 In-Reply-To: <7e354aa295b6dbac92baa4ec5f4bc39f4f4d0053.1566907520.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik Cc: kostja@tarantool.org, alexander.turenko@tarantool.org Thanks for the patch! Currently sizeof(struct port) is 64, sizeof(struct port_sql) is 56. It means, that one new flag port_sql fits easily. I don't think we need that patch now. On 27/08/2019 15:34, Nikita Pettik wrote: > We are going to extend context of struct port_sql. One already inherits > struct port_tuple, which makes it size barely fits into 48 bytes of > padding of basic structure (struct port). Hence, let's increase padding > a bit to be able to add at least one more member to struct port_sql. > --- > src/lib/core/port.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/core/port.h b/src/lib/core/port.h > index 09a026df5..abe21aa53 100644 > --- a/src/lib/core/port.h > +++ b/src/lib/core/port.h > @@ -113,7 +113,7 @@ struct port { > * Implementation dependent content. Needed to declare > * an abstract port instance on stack. > */ > - char pad[48]; > + char pad[52]; > }; > > /** Is not inlined just to be exported. */ >