From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6125D2820D for ; Fri, 22 Feb 2019 07:20:27 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jnB48lnHoWIG for ; Fri, 22 Feb 2019 07:20:27 -0500 (EST) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1029925868 for ; Fri, 22 Feb 2019 07:20:27 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v1 0/4] sql: store regular identifiers in case-normal form References: From: Vladislav Shpilevoy Message-ID: Date: Fri, 22 Feb 2019 15:20:25 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov Hi! Thanks for the patch! On 15/02/2019 16:30, Kirill Shcherbatov wrote: > Perform SQL name normalization: cast name to the upper-case > (via Unicode Character Folding). Casing is locale-dependent > and context-sensitive. The result may be longer or shorter > than the original. For example, ß is converted to SS. > The result is similar to SQL UPPER function. > > Performed extensive code refactoring to pass parser instance in > routines that use sql_normalize_name function. This makes > possible to raise an error in case of normalizing failure. > > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3991-fix-names-normalization > Issue: https://github.com/tarantool/tarantool/issues/3991 Issue 3991 is about vshard integration. Please, check your links next time. The correct issue is 3931, as I understand. Talking about the patchset - I do not understand a point of the first 3 patches. I see, that the only reason why you pass the parser is a wish to set nErr. Why instead not to just do diag_set, return -1, and check for that in all upper functions, until parser is already in one of them? This how all box functions work with SQL right now - they do not take Vdbe, nor Parse. They just set diag and return -1. Our global goal is to get rid of parser nErr, not spread it more. Please, do it. > > Kirill Shcherbatov (4): > sql: patch sql_name_from_token to use Parser > sql: patch sql_trigger_step_allocate to use Parser > sql: patch sql_expr_create routine to use Parser > sql: store regular identifiers in case-normal form > > src/box/lua/lua_sql.c | 11 +- > src/box/sql/alter.c | 2 +- > src/box/sql/analyze.c | 2 +- > src/box/sql/build.c | 212 +++++++++------------ > src/box/sql/delete.c | 2 +- > src/box/sql/expr.c | 256 ++++++++++++-------------- > src/box/sql/fkey.c | 128 +++++++------ > src/box/sql/parse.y | 60 +++--- > src/box/sql/pragma.c | 11 +- > src/box/sql/resolve.c | 41 ++--- > src/box/sql/select.c | 70 ++++--- > src/box/sql/sqlInt.h | 255 +++++++++++++++++++++++-- > src/box/sql/trigger.c | 201 +++++++++----------- > src/box/sql/util.c | 42 +++-- > src/box/sql/wherecode.c | 3 +- > src/box/sql/whereexpr.c | 10 +- > test/sql-tap/identifier_case.test.lua | 12 +- > 17 files changed, 753 insertions(+), 565 deletions(-) > > -- > 2.20.1 > >