From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B0FF6276FE for ; Thu, 26 Jul 2018 17:27:01 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K6jHsdoX-FaK for ; Thu, 26 Jul 2018 17:27:01 -0400 (EDT) Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 064642759C for ; Thu, 26 Jul 2018 17:27:00 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing crossengine sql References: <281C2B94-5BA3-4868-B3A5-53234E2DCA4D@tarantool.org> <12091997-2a63-951d-9477-86c3429d981d@tarantool.org> <589c2e7f-7701-d075-8c91-6d5707e6a9a5@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Fri, 27 Jul 2018 00:26:57 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Thanks for the fixes! I have pushed my own on the branch. Please, squash. Sorry, I was wrong about txn != NULL omitting. If we omit it, then for ephemeral spaces we do not start ro stmt, but commit it. It is not correct. Your code works only because commit_ro() is no-op when we have an active transaction. But it can change in future.