From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 830117064F; Fri, 12 Nov 2021 02:54:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 830117064F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1636674875; bh=YYqmMDESDHuZkjVH/IubwxMLOe1mlFPs0x96PIAtrew=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=SbTz1j/PR1MLjcxj/BytKK15KVVK8UsD0xpBxKNL/ow2tLA79YZtKPxh4vVLl+xlX 73aQ7xA0fggXRDV9h+La+dU1B15eieh5iAvgfq8jSivtcKIbSoLquWuqyut+RuTW+x hFEXE23wA1Ei7kDBii9u5KaYMmC2KouCU0yNfGdI= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 729296FC82 for ; Fri, 12 Nov 2021 02:54:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 729296FC82 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mlJtn-0003tY-MP; Fri, 12 Nov 2021 02:54:32 +0300 To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org Date: Fri, 12 Nov 2021 00:54:19 +0100 Message-Id: X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9731B3922EC063979DD5E01717F989B5F47BAD767D6B13F3A00894C459B0CD1B9E4C79426566308CD8A01296F63A1FB027F76FE7EF67E38FF3EC79052E9E97693 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7180ADF26E81B0C77EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375FE8AD9F0D2764EB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A7DA613F96F147D29AE011EC14405B8F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50537BF44C8E1EC058A4B0E440BD262664C X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C4C7A0BC55FA0FE5FC3C0B852DA0DA35D1729220213E50742301EB7584DAA7D001B1881A6453793CE9C32612AADDFBE0617B34A58113D5E3C69510FB958DCE06DB6ED91DBE5ABE359ADBCB5631A0A9D21FB129A6C9085D3B6193EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D50AEDB859DBAD98103ED15B98D4816C5B68C8EE45154C81A7F12F0B62D3299C90E87B5B98E1BA71D7E09C32AA3244C38B18C0F198E2AB609E8C8BE70CA066451E887DA02A9F7BF729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj4t8MBgWr8bLgKs+qEjGmww== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D41F4B2F91ECFD4E683E190347003DEC33841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 00/11] ER_READONLY reason X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Changes in v2: - A lot of minor fixes in all the commits; - libuuid is moved into libcore; - ER_READONLY message got the same details as in the fields. Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5568-err-readonly-reason Issue: https://github.com/tarantool/tarantool/issues/5568 Vladislav Shpilevoy (11): diag: return created error from diag_set() uuid: move into libcore error: introduce error_payload error: move code to struct error from ClientError error: use error_payload to store optional members error: use error_payload in MessagePack codecs error: use error_payload in Lua luatest: copy config in cluster:build_server() luatest: add new helpers for 'server' object box: enrich ER_READONLY with new details error: report ER_READONLY reason in message .../unreleased/gh-5568-readonly-reason.md | 4 + extra/exports | 3 +- src/CMakeLists.txt | 3 +- src/box/applier.h | 2 +- src/box/bind.h | 2 +- src/box/box.cc | 69 ++- src/box/errcode.h | 2 +- src/box/error.cc | 57 +-- src/box/error.h | 60 +-- src/box/field_def.c | 4 +- src/box/index.cc | 4 +- src/box/lua/serialize_lua.c | 2 +- src/box/mp_error.cc | 197 +++----- src/box/msgpack.c | 2 +- src/box/replication.h | 2 +- src/box/sql/mem.c | 2 +- src/box/sql/mem.h | 2 +- src/box/tuple.h | 2 +- src/box/tuple_compare.cc | 8 +- src/box/xlog.h | 2 +- src/box/xrow.h | 2 +- src/lib/CMakeLists.txt | 1 - src/lib/core/CMakeLists.txt | 3 + src/lib/core/crash.c | 2 +- src/lib/core/diag.c | 37 +- src/lib/core/diag.h | 109 +++- src/lib/core/error_payload.c | 301 +++++++++++ src/lib/core/error_payload.h | 190 +++++++ src/lib/core/exception.cc | 8 +- src/lib/core/exception.h | 66 +++ src/lib/{uuid => core}/mp_uuid.c | 0 src/lib/{uuid => core}/mp_uuid.h | 0 src/lib/{uuid => core}/tt_uuid.c | 0 src/lib/{uuid => core}/tt_uuid.h | 0 src/lib/mpstream/CMakeLists.txt | 2 +- src/lib/mpstream/mpstream.c | 2 +- src/lib/swim/CMakeLists.txt | 2 +- src/lib/swim/swim_io.h | 2 +- src/lib/swim/swim_proto.h | 2 +- src/lib/uuid/CMakeLists.txt | 2 - src/lua/error.lua | 84 ++-- src/lua/init.lua | 24 - src/lua/msgpack.c | 6 +- src/lua/tnt_msgpuck.h | 2 +- src/lua/utils.c | 2 +- test/box/error.result | 4 +- test/box/error.test.lua | 2 +- test/engine/func_index.result | 3 +- test/luatest_helpers/cluster.lua | 1 + test/luatest_helpers/server.lua | 66 ++- .../gh_5568_read_only_reason_test.lua | 304 ++++++++++++ test/replication/anon.result | 6 +- test/replication/catch.result | 4 +- test/replication/election_qsync.result | 11 +- test/replication/election_qsync.test.lua | 4 +- .../gh-6034-qsync-limbo-ownership.result | 22 +- .../gh-6034-qsync-limbo-ownership.test.lua | 8 +- test/sql-tap/CMakeLists.txt | 2 +- test/sql-tap/gh-6024-funcs-return-bin.c | 2 +- test/sql-tap/sql_uuid.c | 2 +- test/unit/CMakeLists.txt | 4 +- test/unit/error.c | 466 ++++++++++++++++++ test/unit/error.result | 161 ++++++ test/unit/mp_error.cc | 76 ++- test/unit/mp_error.result | 27 +- test/unit/swim_proto.c | 2 +- test/unit/swim_test_utils.c | 2 +- test/unit/swim_test_utils.h | 2 +- test/unit/uuid.c | 4 +- test/unit/vy_iterators_helper.c | 2 +- test/unit/xrow.cc | 2 +- test/vinyl/misc.result | 2 +- third_party/lua-cjson/lua_cjson.c | 2 +- third_party/lua-yaml/lyaml.cc | 2 +- 74 files changed, 2069 insertions(+), 404 deletions(-) create mode 100644 changelogs/unreleased/gh-5568-readonly-reason.md create mode 100644 src/lib/core/error_payload.c create mode 100644 src/lib/core/error_payload.h rename src/lib/{uuid => core}/mp_uuid.c (100%) rename src/lib/{uuid => core}/mp_uuid.h (100%) rename src/lib/{uuid => core}/tt_uuid.c (100%) rename src/lib/{uuid => core}/tt_uuid.h (100%) delete mode 100644 src/lib/uuid/CMakeLists.txt create mode 100644 test/replication-luatest/gh_5568_read_only_reason_test.lua create mode 100644 test/unit/error.c create mode 100644 test/unit/error.result -- 2.24.3 (Apple Git-128)