From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 369186EC58; Mon, 2 Aug 2021 20:25:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 369186EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627925128; bh=dygKQTbwgLQfuhVCCEjxy1tMY/TbaO6J+diZ3xNpYZY=; h=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=xZ48vHhs6dnIVYeZ9pTJiDTqrrb7VJZ6C9QfLXUa5mgQImKXNMUq0qGv/B0gIjrUA cLXg/0sRJcJeiTREDtTJ9p8p0IMLeJiRmjHyTgsPsWO0IV+3JlFClPY1H/EfAWyoaH dN2w4d9zbKoltn0914TFGyU55QQP1UurEi/kp3FQ= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A24CD6EC58 for ; Mon, 2 Aug 2021 20:25:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A24CD6EC58 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1mAbgr-0001kR-Ua; Mon, 02 Aug 2021 20:25:26 +0300 To: imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org Date: Mon, 2 Aug 2021 20:25:25 +0300 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F53808504098F93D5DCD369C90A90FE22F0A81E679C11FE595D0E348418920D247009EB75C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637ED2BA022FBF94AB68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84E1B438B09294B856458F0C6FA1302CB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEFAD5A440E159F97D8F49F126DDB898E8D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A5ED62E35AC703CCBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE798228CBAD4AC77F6731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505F028303C9B47EEC576AF8084D0130D6F X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C85811CA530B5049153AFF801E94CA36A3C247B9DCC5295399C2B6934AE262D3EE7EAB7254005DCEDD39702B95798B1671E0A4E2319210D9B64D260DF9561598F01A9E91200F654B0257B9C11E3AC915C8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C1E32F4AD4B2486B6B7A8D65C80A0DC3B129ABF09CA0C00DE2E87B4B609D8C4C8AC30D408F4B1E121D7E09C32AA3244CAE0115D932747E52AE1B157253A276FDE3D93501275E802F729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9N286KAyvN7sDYMEx9NMpQ== X-Mailru-Sender: 83DC58D0E026EF5214980281B38C45576BACC32DCD975C46A90FE22F0A81E6797345D355D45E21A65105BD0848736F9966FEC6BF5C9C28D97E07721503EA2E00ED97202A5A4E92BF7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 0/3] Fix explicit casts X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: imeevma@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This patch fixes the explicit cast to comply with the new rules. According to these rules, BOOLEAN and VARBINARY can no longer be cast to numeric types. https://github.com/tarantool/tarantool/issues/4470 https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-fix-explicit-cast Changes in v2: - Change of str_to_bool() were moved in new patch. Mergen Imeev (3): sql: disallow explicit cast of BOOLEAN to number sql: disallow explicit cast of VARBINARY to number sql: fix STRING to BOOLEAN explicit cast .../unreleased/gh-4470-explicit-cast.md | 8 + src/box/sql/mem.c | 98 +++------ test/sql-tap/cast.test.lua | 186 +++++++++++++++--- test/sql-tap/cse.test.lua | 18 +- test/sql-tap/e_select1.test.lua | 3 +- ...-4766-wrong-cast-from-blob-to-int.test.lua | 40 ---- test/sql-tap/in1.test.lua | 17 +- test/sql-tap/misc3.test.lua | 12 +- test/sql-tap/numcast.test.lua | 18 +- test/sql/boolean.result | 71 +++---- test/sql/boolean.test.sql | 13 +- test/sql/types.result | 14 +- 12 files changed, 271 insertions(+), 227 deletions(-) create mode 100644 changelogs/unreleased/gh-4470-explicit-cast.md delete mode 100755 test/sql-tap/gh-4766-wrong-cast-from-blob-to-int.test.lua -- 2.25.1