From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5B71A6EC41; Tue, 29 Jun 2021 01:13:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B71A6EC41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624918387; bh=dy7x27hxQ1Kg64JE7/yzsg6ocRB17oa4Jdo1jzgYcrY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=kOyydv449TievQKLiRj5wSoA9qjScRze38AWWD7u6mNhsCz/VlVEcutd+ex6n9pwG +LyxFEgUErYnliM8ja8adM/PB4nVtKOC70aMCAjXVSm/XRADj8N1MVS7cZToPmHqYn WNm/7dmVmFEXDKYv7dWMZ5oAX9yxc09Xr+k6KtHw= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0F2B56EC40 for ; Tue, 29 Jun 2021 01:13:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F2B56EC40 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1lxzV2-0007oC-03; Tue, 29 Jun 2021 01:13:04 +0300 To: v.shpilevoy@tarantool.org, gorcunov@gmail.com Date: Tue, 29 Jun 2021 01:12:46 +0300 Message-Id: X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB64496B12B6C6FB871CAFB561BC326F0E182A05F5380850400F61D50DA5B1BDB8750856126A6814DFB46B033F4B9486128312A077CC5E9B44 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7696D01AF671C4816EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063707C9A2DE1D52FEB28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D827637F24BC240C994C07E32EE34C6FFA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C837C4FEFBD186071C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831A91E565E6410D4C42D680659EFB54793 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975CD87436A60A035F40867820F64D4AB3493F623EDED96992E69C2B6934AE262D3EE7EAB7254005DCEDD95CC81E7494ECA192E1F3B950BCE216D137639923C070AB9EC1289D7B63F6F4BDC6A1CF3F042BAD6DF99611D93F60EF6EA1BA7CA28B4A74699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9873270276D4334D0562747EAC057192BC855492F4028D8FE39D09FCAEDE53367097959B5C95E571D7E09C32AA3244CC48A4B96579DEEA67160440B34E530596C24832127668422927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXjjQb0ILB/OAmpz4E71aTNb X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A446C3FEE19542AA4C0E2C94C3BD3CD768B34A9500AE01DFC9AF424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: [Tarantool-patches] [PATCH v3 00/12] forbid implicit limbo ownership transition X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Changes in v3: - change demote() behaviour as discussed with Vlad: * make it work only on the current leader * make it demote the current leader and always bump the term - change how limbo and raft snapshots are sent in response to JOIN: * encode replica's version in JOIN request * introduce a special stage: JOIN_META with raft and limbo snapshots. Send it based on replica's version. https://github.com/tarantool/tarantool/issues/5438 https://github.com/tarantool/tarantool/issues/6034 https://github.com/tarantool/tarantool/tree/sp/gh-6034-empty-limbo-transition Serge Petrenko (12): replication: always send raft state to subscribers txn_limbo: fix promote term filtering raft: refactor raft_new_term() box: make promote always bump the term replication: forbid implicit limbo owner transition box: allow calling promote on a candidate box: introduce `box.ctl.demote` txn_limbo: persist the latest effective promote in snapshot replication: encode version in JOIN request replication: add META stage to JOIN replication: send latest effective promote in initial join replication: send current Raft term in join response src/box/applier.cc | 27 ++- src/box/box.cc | 101 ++++++---- src/box/box.h | 3 + src/box/errcode.h | 2 + src/box/iproto_constants.h | 12 +- src/box/lua/ctl.c | 9 + src/box/lua/info.c | 4 +- src/box/memtx_engine.c | 32 +++ src/box/raft.c | 36 ++++ src/box/raft.h | 4 + src/box/relay.cc | 36 +++- src/box/relay.h | 4 +- src/box/txn_limbo.c | 90 ++++++--- src/box/txn_limbo.h | 14 ++ src/box/xrow.c | 4 +- src/box/xrow.h | 25 ++- src/lib/raft/raft.c | 3 +- test/box/alter.result | 2 +- test/box/error.result | 2 + test/replication/election_basic.result | 3 + test/replication/election_basic.test.lua | 1 + test/replication/election_qsync.result | 3 + test/replication/election_qsync.test.lua | 1 + .../gh-4114-local-space-replication.result | 7 +- .../gh-4114-local-space-replication.test.lua | 4 +- .../gh-5140-qsync-casc-rollback.result | 6 + .../gh-5140-qsync-casc-rollback.test.lua | 2 + .../gh-5144-qsync-dup-confirm.result | 6 + .../gh-5144-qsync-dup-confirm.test.lua | 2 + .../gh-5163-qsync-restart-crash.result | 6 + .../gh-5163-qsync-restart-crash.test.lua | 2 + .../gh-5167-qsync-rollback-snap.result | 6 + .../gh-5167-qsync-rollback-snap.test.lua | 2 + .../gh-5195-qsync-replica-write.result | 10 +- .../gh-5195-qsync-replica-write.test.lua | 6 +- .../gh-5213-qsync-applier-order-3.result | 9 + .../gh-5213-qsync-applier-order-3.test.lua | 3 + .../gh-5213-qsync-applier-order.result | 6 + .../gh-5213-qsync-applier-order.test.lua | 2 + .../replication/gh-5288-qsync-recovery.result | 6 + .../gh-5288-qsync-recovery.test.lua | 2 + .../gh-5298-qsync-recovery-snap.result | 6 + .../gh-5298-qsync-recovery-snap.test.lua | 2 + .../gh-5426-election-on-off.result | 3 + .../gh-5426-election-on-off.test.lua | 1 + .../gh-5433-election-restart-recovery.result | 3 + ...gh-5433-election-restart-recovery.test.lua | 1 + ...sync-clear-synchro-queue-commit-all.result | 3 + ...nc-clear-synchro-queue-commit-all.test.lua | 1 + test/replication/gh-5438-raft-state.result | 66 ++++++ test/replication/gh-5438-raft-state.test.lua | 29 +++ test/replication/gh-5440-qsync-ro.result | 133 ------------ test/replication/gh-5440-qsync-ro.test.lua | 53 ----- .../gh-5446-qsync-eval-quorum.result | 7 + .../gh-5446-qsync-eval-quorum.test.lua | 3 + .../gh-5506-election-on-off.result | 3 + .../gh-5506-election-on-off.test.lua | 1 + .../gh-5566-final-join-synchro.result | 6 + .../gh-5566-final-join-synchro.test.lua | 2 + .../gh-5874-qsync-txn-recovery.result | 6 + .../gh-5874-qsync-txn-recovery.test.lua | 2 + .../gh-6032-promote-wal-write.result | 3 + .../gh-6032-promote-wal-write.test.lua | 1 + .../gh-6034-limbo-ownership.result | 189 ++++++++++++++++++ .../gh-6034-limbo-ownership.test.lua | 69 +++++++ .../gh-6034-promote-bump-term.result | 40 ++++ .../gh-6034-promote-bump-term.test.lua | 17 ++ .../gh-6057-qsync-confirm-async-no-wal.result | 7 + ...h-6057-qsync-confirm-async-no-wal.test.lua | 3 + test/replication/hang_on_synchro_fail.result | 6 + .../replication/hang_on_synchro_fail.test.lua | 2 + test/replication/qsync_advanced.result | 12 ++ test/replication/qsync_advanced.test.lua | 4 + test/replication/qsync_basic.result | 33 ++- test/replication/qsync_basic.test.lua | 16 +- test/replication/qsync_errinj.result | 6 + test/replication/qsync_errinj.test.lua | 2 + test/replication/qsync_snapshots.result | 6 + test/replication/qsync_snapshots.test.lua | 2 + test/replication/qsync_with_anon.result | 6 + test/replication/qsync_with_anon.test.lua | 2 + test/replication/replica_rejoin.result | 77 ++++--- test/replication/replica_rejoin.test.lua | 50 ++--- test/replication/suite.cfg | 4 +- test/unit/raft.c | 15 +- test/unit/raft.result | 3 +- 86 files changed, 1039 insertions(+), 372 deletions(-) create mode 100644 test/replication/gh-5438-raft-state.result create mode 100644 test/replication/gh-5438-raft-state.test.lua delete mode 100644 test/replication/gh-5440-qsync-ro.result delete mode 100644 test/replication/gh-5440-qsync-ro.test.lua create mode 100644 test/replication/gh-6034-limbo-ownership.result create mode 100644 test/replication/gh-6034-limbo-ownership.test.lua create mode 100644 test/replication/gh-6034-promote-bump-term.result create mode 100644 test/replication/gh-6034-promote-bump-term.test.lua -- 2.30.1 (Apple Git-130)