From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Cyrill Gorcunov <gorcunov@tarantool.org>, Roman Khabibov <roman.habibov@tarantool.org> Cc: Alexander Turenko <alexander.turenko@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 0/4] RFC: Isolate serializer helpers Date: Wed, 23 Jun 2021 22:12:38 +0300 [thread overview] Message-ID: <cover.1624474915.git.alexander.turenko@tarantool.org> (raw) Moved the serializer helpers into its own compilation unit, add some comments and a basic test: everything is just to simplify diving into this code. Guys, please, look, whether it seems useful enough to include into tarantool's mainline? Should we name it serializer.[ch] or somehow like serializer_helpers.[ch]? Part of https://github.com/tarantool/tarantool/issues/3228 Branch: Totktonada/gh-3228-extract-serializer-helpers Alexander Turenko (4): lua: move serializer helpers into its own file lua: move luaL_newserializer() comment into header lua: split serializer functions into sections test: add a basic unit test for serializer helpers src/CMakeLists.txt | 1 + src/box/lua/call.c | 1 + src/box/lua/console.c | 1 + src/box/lua/execute.c | 1 + src/box/lua/info.c | 1 + src/box/lua/init.c | 2 + src/box/lua/serialize_lua.c | 1 + src/box/lua/slab.c | 1 + src/box/lua/tuple.c | 1 + src/box/sql/mem.c | 1 + src/lua/decimal.c | 2 + src/lua/fiber.c | 1 + src/lua/init.c | 5 + src/lua/msgpack.c | 1 + src/lua/msgpack.h | 1 + src/lua/pickle.c | 1 + src/lua/serializer.c | 653 ++++++++++++++++++++++++++++++ src/lua/serializer.h | 376 +++++++++++++++++ src/lua/utils.c | 601 +-------------------------- src/lua/utils.h | 292 +------------ test/unit/CMakeLists.txt | 3 + test/unit/serializer.c | 444 ++++++++++++++++++++ test/unit/serializer.result | 135 ++++++ third_party/lua-cjson/lua_cjson.c | 1 + third_party/lua-yaml/lyaml.cc | 1 + 25 files changed, 1639 insertions(+), 889 deletions(-) create mode 100644 src/lua/serializer.c create mode 100644 src/lua/serializer.h create mode 100644 test/unit/serializer.c create mode 100644 test/unit/serializer.result -- 2.31.1
next reply other threads:[~2021-06-23 19:13 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-23 19:12 Alexander Turenko via Tarantool-patches [this message] 2021-06-23 19:12 ` [Tarantool-patches] [PATCH 1/4] lua: move serializer helpers into its own file Alexander Turenko via Tarantool-patches 2021-07-04 13:10 ` Vladislav Shpilevoy via Tarantool-patches 2021-07-05 6:30 ` Alexander Turenko via Tarantool-patches 2021-07-05 20:59 ` Vladislav Shpilevoy via Tarantool-patches 2021-06-23 19:12 ` [Tarantool-patches] [PATCH 2/4] lua: move luaL_newserializer() comment into header Alexander Turenko via Tarantool-patches 2021-06-23 19:12 ` [Tarantool-patches] [PATCH 3/4] lua: split serializer functions into sections Alexander Turenko via Tarantool-patches 2021-06-23 19:12 ` [Tarantool-patches] [PATCH 4/4] test: add a basic unit test for serializer helpers Alexander Turenko via Tarantool-patches 2021-06-24 6:17 ` [Tarantool-patches] [PATCH 0/4] RFC: Isolate " Cyrill Gorcunov via Tarantool-patches 2021-06-28 6:31 ` Cyrill Gorcunov via Tarantool-patches 2021-07-04 13:09 ` Vladislav Shpilevoy via Tarantool-patches 2021-07-05 6:30 ` Alexander Turenko via Tarantool-patches 2021-07-07 10:08 ` Alexander Turenko via Tarantool-patches 2021-07-07 19:09 ` Alexander Turenko via Tarantool-patches 2021-07-07 22:16 ` Vladislav Shpilevoy via Tarantool-patches 2021-07-12 7:51 ` Alexander Turenko via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1624474915.git.alexander.turenko@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=gorcunov@tarantool.org \ --cc=roman.habibov@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/4] RFC: Isolate serializer helpers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox