From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: v.shpilevoy@tarantool.org, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 0/3] fix assertion failure in box.ctl.promote() Date: Thu, 20 May 2021 12:02:33 +0300 [thread overview] Message-ID: <cover.1621501007.git.sergepetrenko@tarantool.org> (raw) The patchset fixes an assertion failure in box.ctl.promote() if it was called during an on-going WAL write. The issue is only present when promote is called on the limbo owner itself, because in this case the last synchronous entries lsn is not yet known. https://github.com/tarantool/tarantool/issues/6032 https://github.com/tarantool/tarantool/tree/sp/gh-6032-promote-wal-write Serge Petrenko (3): box: make txn reference the limbo entry txn_limbo: move lsn assignment to journal completion callback box: fix an assertion failure in box.ctl.promote() src/box/box.cc | 26 ++--- src/box/txn.c | 40 +++---- src/box/txn.h | 2 + src/box/txn_limbo.c | 42 +++++++ src/box/txn_limbo.h | 8 ++ .../gh-6032-promote-wal-write.result | 108 ++++++++++++++++++ .../gh-6032-promote-wal-write.test.lua | 41 +++++++ test/replication/suite.cfg | 1 + 8 files changed, 235 insertions(+), 33 deletions(-) create mode 100644 test/replication/gh-6032-promote-wal-write.result create mode 100644 test/replication/gh-6032-promote-wal-write.test.lua -- 2.30.1 (Apple Git-130)
next reply other threads:[~2021-05-20 9:02 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-20 9:02 Serge Petrenko via Tarantool-patches [this message] 2021-05-20 9:02 ` [Tarantool-patches] [PATCH 1/3] box: make txn reference the limbo entry Serge Petrenko via Tarantool-patches 2021-05-20 9:02 ` [Tarantool-patches] [PATCH 2/3] txn_limbo: move lsn assignment to journal completion callback Serge Petrenko via Tarantool-patches 2021-05-20 9:02 ` [Tarantool-patches] [PATCH 3/3] box: fix an assertion failure in box.ctl.promote() Serge Petrenko via Tarantool-patches 2021-05-23 12:18 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-25 10:39 ` Serge Petrenko via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1621501007.git.sergepetrenko@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/3] fix assertion failure in box.ctl.promote()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox