From: Ilya Kosarev <i.kosarev@tarantool.org> To: v.shpilevoy@tarantool.org, alyapunov@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v9 0/3] iproto: greeting enhancement Date: Thu, 24 Dec 2020 23:13:00 +0300 [thread overview] Message-ID: <cover.1608840673.git.i.kosarev@tarantool.org> (raw) These patches move greeting from tx thread to iproto and introduce improvements into iproto logic. Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3776-handling-connections-in-iproto Issue: https://github.com/tarantool/tarantool/issues/3776 Changes in v2: - docbot request provided - ChangeLog provided - net_send_msg() used instead of net_send_error() where needed - error cases made clear in iproto_msg_decode() - replaced net_check_connection() with iproto_connection_fail() predicate - improved tx session initialization fail processing to avoid extra tries - fixed obuf_dup() fail processing in iproto_process_connect() - added some comments - some comments style fixed Changes in v3: - added braces to the confusing one-line if statement - updated ChangeLog - added description for iproto_msg_decode() - simplified error processing in iproto_msg_decode() Changes in v4: - fixed msg->close_connection initialization bug - fixed false-sharing problem in iproto_connection struct - added needed assertion - added needed comments - names refactoring - simplified patch a bit: removed extra return value, extra Changes in v5: - reworked to avoid lazy initialization and extra changes Changes in v6: - some changes are picket out into separate commits - main commit message rewrited to become more comprehensive - removed some extra changes - style fixes - greeting allocation fixed Changes in v7: - fixed functions signatures & added comments - partial greeting write taken into account - added needed state Changes in v8: - style fix - iproto now starts to read right after greeting and can close the socket Changes in v9: - simplified processing of closed connections in tx (no extra state reading) - removed extra iproto_connection_stop_msg_max_limit() not applicable call Ilya Kosarev (3): iproto: move msg fields initialization to iproto_msg_new() iproto: fix comment and add assert on destruction iproto: move greeting from tx thread to iproto src/box/iproto.cc | 194 ++++++++++++++---- test/app/gh-4787-netbox-empty-errmsg.result | 18 -- test/app/gh-4787-netbox-empty-errmsg.test.lua | 8 - 3 files changed, 150 insertions(+), 70 deletions(-) -- 2.17.1
next reply other threads:[~2020-12-24 20:13 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-24 20:13 Ilya Kosarev [this message] 2020-12-24 20:13 ` [Tarantool-patches] [PATCH v9 1/3] iproto: move msg fields initialization to iproto_msg_new() Ilya Kosarev 2020-12-24 20:13 ` [Tarantool-patches] [PATCH v9 2/3] iproto: fix comment and add assert on destruction Ilya Kosarev 2020-12-28 11:49 ` Vladislav Shpilevoy 2020-12-28 11:49 ` Vladislav Shpilevoy 2020-12-24 20:13 ` [Tarantool-patches] [PATCH v9 3/3] iproto: move greeting from tx thread to iproto Ilya Kosarev 2020-12-28 11:21 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1608840673.git.i.kosarev@tarantool.org \ --to=i.kosarev@tarantool.org \ --cc=alyapunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v9 0/3] iproto: greeting enhancement' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox