From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 203C245C305 for ; Fri, 4 Dec 2020 11:05:46 +0300 (MSK) From: "Alexander V. Tikhonov" Date: Fri, 4 Dec 2020 11:05:38 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v2 0/2] test: flaky hang vinyl/ddl.test.lua test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandr Lyapunov , Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Patchset consists of 2 commits: 1. Revert "Fix flaky test engine/ddl" Found that the previous fix of the engine/ddl.test.lua test committed with: 5f96ee5907672bd32dd7fe8dad144ac3d328187f ('Fix flaky test engine/ddl') did not fix the issue #4353 in real and it was reverted. 2. test: flaky hang vinyl/ddl.test.lua test Found hanging test vinyl/ddl.test.lua on: [159] inspector:wait_cond(function() return box.space.test.index.pk:count() == box.space.test.index.tk:count() end) [159] --- [159] - true [159] ... [159] -box.snapshot() [159] ---- [159] -- ok [159] -... The real issue happend before it when test failed on: [091] --- engine/ddl.result Thu May 14 16:12:09 2020 [091] +++ engine/ddl.reject Fri May 15 04:15:07 2020 [091] @@ -2558,7 +2558,7 @@ [091] ... [091] inspector:wait_cond(function() return box.space.test.index.pk:count() == box.space.test.index.sk:count() end) [091] --- [091] -- true [091] +- false [091] ... Our tests have structure when different standalone subtests exists in the test files. To be able to check all of them this hang must be neutralized to give the next standalone subtest ability to pass. To avoid of this hang decided to disable box.snapshot check if the previous check of the current subtest failed. Needed for #4353 Alexander V. Tikhonov (2): Revert "Fix flaky test engine/ddl" test: flaky hang vinyl/ddl.test.lua test --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4353-hang-ddl Issue: https://github.com/tarantool/tarantool/issues/4353 test/engine/ddl.result | 91 ++++++++++++++++++++++++++-------------- test/engine/ddl.test.lua | 76 ++++++++++++++++++++++++++------- test/engine/suite.ini | 2 +- 3 files changed, 122 insertions(+), 47 deletions(-) -- 2.24.1 (Apple Git-126)