From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Alexander Turenko <alexander.turenko@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1 0/2] tarantoolctl: add signal in stop/restart options Date: Wed, 11 Nov 2020 08:21:32 +0300 [thread overview] Message-ID: <cover.1605071860.git.avtikhon@tarantool.org> (raw) Found that some of the instances could not be killed with SIGTERM signal and it really needed SIGKILL signal to be sure that the instance would be terminated. Otherwise some tests may fail, like: No output during 120 seconds. Will abort after 120 seconds without output. List of workers not reporting the status: - 001_engine [engine/json.test.lua, memtx] at var/001_engine/json.result:598 Test hung! Result content mismatch: --- engine/json.result Fri Nov 6 08:35:45 2020 +++ var/001_engine/json.result Mon Nov 9 03:48:40 2020 @@ -596,248 +596,3 @@ - ok ... test_run:cmd("restart server default") -engine = test_run:get_cfg('engine') ---- -… Test run uses 'tarantoolctl' tool for commands in format "restart server default", and 'tarantoolctl' had only single way to kill it using SIGTERM signal. To implement ability to use it with SIGKILL was added additional non-mandatory option to stop and restart 'tarantoolctl' commands, like: tarantoolctl stop <instance> [--signal=SIGKILL] tarantoolctl restart <instance> [--signal=SIGKILL] This options didn't change the backward compatibility of 'tarantoolctl' tool, but gave the tests ability to stop and restart instances in the following way: test_run:cmd("stop server default with signal=KILL") test_run:cmd("restart server default with signal=KILL") It helped to fix the issue with hanging instances in the needed tests. After test-run changed for the new 'tarantoolctl' format for 'restart' and 'stop' commands some tests had to be updated due to checked it. Closes #5510 Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5510-tarantoolctl-signals Issue: https://github.com/tarantool/tarantool/issues/5510 Alexander V. Tikhonov (2): tarantoolctl: add signal in stop/restart options Update tests for the new tarantoolctl format extra/dist/tarantoolctl.in | 22 ++++++++++++++++++---- test/app/cmdline.result | 6 +++++- test/app/cmdline.test.lua | 3 ++- test/replication/bootstrap_leader.result | 2 +- test/replication/bootstrap_leader.test.lua | 2 +- 5 files changed, 27 insertions(+), 8 deletions(-) -- 2.25.1
next reply other threads:[~2020-11-11 5:21 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-11 5:21 Alexander V. Tikhonov [this message] 2020-11-11 5:21 ` [Tarantool-patches] [PATCH v1 1/2] " Alexander V. Tikhonov 2020-11-11 5:21 ` [Tarantool-patches] [PATCH v1 2/2] Update tests for the new tarantoolctl format Alexander V. Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1605071860.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 0/2] tarantoolctl: add signal in stop/restart options' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox