Tarantool development patches archive
 help / color / mirror / Atom feed
From: Timur Safin <tsafin@tarantool.org>
To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH 0/2] module_api: followup changes for merger part
Date: Thu, 22 Oct 2020 13:20:39 +0300	[thread overview]
Message-ID: <cover.1603360022.git.tsafin@tarantool.org> (raw)

There were few complains about comments in the patchset sent
for issue #5384:
- we have been asked to extend reasonably ibuf.h documentation, making 
  it more self-contained;
- and to fix module_api test comments, making them more doxygen

P.S.
Actualy I don't know whether we really want it be committed to the 
2.6 we plan to release soon. But looks like commenting changes 
in the external API might still be a good idea. You decide.

Timur Safin (2):
  module api: proper documentation for the ibuf wrapper
  module api: polish module_api test

 src/box/ibuf.h            | 33 ++++++++++++++++++++++++++++++---
 test/app-tap/module_api.c |  8 ++++----
 2 files changed, 34 insertions(+), 7 deletions(-)

-- 
2.20.1

             reply	other threads:[~2020-10-22 10:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 10:20 Timur Safin [this message]
2020-10-22 10:20 ` [Tarantool-patches] [PATCH 1/2] module api: proper documentation for the ibuf wrapper Timur Safin
2020-10-22 10:20 ` [Tarantool-patches] [PATCH 2/2] module api: polish module_api test Timur Safin
2020-11-09  5:01   ` Alexander Turenko
2020-11-02 21:13 ` [Tarantool-patches] [PATCH 0/2] module_api: followup changes for merger part Vladislav Shpilevoy
2020-11-09  5:03 ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1603360022.git.tsafin@tarantool.org \
    --to=tsafin@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] module_api: followup changes for merger part' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox