From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
Timur Safin <tsafin@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests
Date: Fri, 16 Oct 2020 15:11:32 +0300 [thread overview]
Message-ID: <cover.1602846789.git.imun@tarantool.org> (raw)
As a result of the review[1] for Timur patch, I've finally got the idea
how to reduce the struggling Kirill faces every time there is a new test
created within LuaJIT third party repo. The series contains of two
patches in both repos:
* the root CMakeLists.txt for test directory is introduced to LuaJIT
repo in scope of the first patch
* the paths in test/CMakeLists.txt are accordingly adjusted
Issue: https://github.com/tarantool/tarantool/issues/5425
LuaJIT repo branches:
* https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake
* https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake-2.5
Tarantool repo branch (need to be cherry-picked to all stable branches):
* https://github.com/tarantool/tarantool/tree/imun/gh-5425-luajit-tests-cmake
CI is not green, but I've done my best. I see neither build fails nor
failures related to the luajit-tap tests here:
* https://gitlab.com/tarantool/tarantool/-/pipelines/203537445
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-October/020266.html
--
2.25.0
next reply other threads:[~2020-10-16 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 12:11 Igor Munkin [this message]
2020-10-16 12:11 ` [Tarantool-patches] [PATCH luajit] test: introduce the root CMakeLists.txt Igor Munkin
2020-10-16 12:12 ` [Tarantool-patches] [PATCH] test: adjust the path to LuaJIT test directory Igor Munkin
2020-10-16 12:33 ` [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests Timur Safin
2020-10-16 12:47 ` Igor Munkin
2020-10-16 12:59 ` Alexander V. Tikhonov
2020-10-16 12:54 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1602846789.git.imun@tarantool.org \
--to=imun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox