From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [Tarantool-patches] [PATCH 1.10 00/16] RFC: module api: extend for external key_def Lua module
Date: Wed, 23 Sep 2020 04:40:13 +0300 [thread overview]
Message-ID: <cover.1600824556.git.alexander.turenko@tarantool.org> (raw)
In-Reply-To: <cover.1600817803.git.alexander.turenko@tarantool.org>
The backport of the patchset to 1.10. I decided to send it to ease
commenting (despite that there is many repeating code).
The status is the same as for the master patchset: it looks ready except
tests. I'll write them.
See the cover letter for the master patchset for details ([1]). My
doubts around the backport are also in the master cover letter.
Issues:
https://github.com/tarantool/tarantool/issues/5313 ('module api: module
API requires C11')
https://github.com/tarantool/tarantool/issues/5273 ('module api: expose
everything that is needed for external key_def module')
Branch:
https://github.com/tarantool/tarantool/tree/Totktonada/gh-5273-expand-module-api-1.10
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-September/019583.html
Alexander Turenko (16):
collation: allow to find a collation by a name
refactoring: adjust contract of luaT_tuple_new()
module api: get rid of typedef redefinitions
WIP: module api: expose box region
WIP: module api/lua: add luaL_iscdata() function
WIP: module api/lua: expose luaT_tuple_new()
WIP: module api/lua: add luaT_tuple_encode()
WIP: refactoring: add API_EXPORT to lua/tuple functions
WIP: refactoring: add API_EXPORT to key_def functions
WIP: refactoring: extract key_def module API functions
WIP: module api: add box_key_def_new_ex()
WIP: module api: add box_key_def_dump_parts()
WIP: module api: expose box_tuple_validate_key_parts()
WIP: module api: expose box_key_def_merge()
WIP: module api: expose box_tuple_extract_key_ex()
WIP: module api: add box_key_def_validate_key()
extra/exports | 14 ++
src/CMakeLists.txt | 6 +-
src/box/CMakeLists.txt | 1 +
src/box/coll_id_cache.c | 50 +++++-
src/box/coll_id_cache.h | 6 +
src/box/index.h | 5 +-
src/box/key_def.c | 53 +-----
src/box/key_def.h | 85 ++++-----
src/box/key_def_api.c | 298 ++++++++++++++++++++++++++++++++
src/box/key_def_api.h | 274 +++++++++++++++++++++++++++++
src/box/lua/space.cc | 2 +-
src/box/lua/tuple.c | 62 +++++--
src/box/lua/tuple.h | 65 ++++++-
src/fiber.c | 24 +++
src/fiber.h | 101 +++++++++++
src/lua/utils.c | 6 +
src/lua/utils.h | 20 +++
test/app-tap/CMakeLists.txt | 6 +
test/app-tap/module_api.c | 2 +
test/unit/CMakeLists.txt | 4 +
test/unit/luaT_tuple_new.c | 175 +++++++++++++++++++
test/unit/luaT_tuple_new.result | 22 +++
test/unit/vy_iterators_helper.c | 1 +
test/unit/vy_mem.c | 1 +
test/unit/vy_point_lookup.c | 1 +
test/unit/vy_write_iterator.c | 1 +
26 files changed, 1151 insertions(+), 134 deletions(-)
create mode 100644 src/box/key_def_api.c
create mode 100644 src/box/key_def_api.h
create mode 100644 test/unit/luaT_tuple_new.c
create mode 100644 test/unit/luaT_tuple_new.result
--
2.25.0
next prev parent reply other threads:[~2020-09-23 1:40 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 1:14 [Tarantool-patches] [PATCH 00/14] " Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 01/14] module api: get rid of typedef redefinitions Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 02/14] WIP: module api: expose box region Alexander Turenko
2020-09-24 22:31 ` Vladislav Shpilevoy
2020-10-08 19:21 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 03/14] WIP: module api/lua: add luaL_iscdata() function Alexander Turenko
2020-09-24 22:32 ` Vladislav Shpilevoy
2020-10-08 21:46 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 04/14] WIP: module api/lua: expose luaT_tuple_new() Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 05/14] WIP: module api/lua: add luaT_tuple_encode() Alexander Turenko
2020-09-24 22:32 ` Vladislav Shpilevoy
2020-10-12 19:06 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 06/14] WIP: refactoring: add API_EXPORT to lua/tuple functions Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 07/14] WIP: refactoring: add API_EXPORT to key_def functions Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 08/14] WIP: refactoring: extract key_def module API functions Alexander Turenko
2020-09-25 22:58 ` Vladislav Shpilevoy
2020-10-07 11:30 ` Alexander Turenko
2020-10-07 22:12 ` Vladislav Shpilevoy
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 09/14] WIP: module api: add box_key_def_new_ex() Alexander Turenko
2020-09-25 22:58 ` Vladislav Shpilevoy
2020-10-09 21:54 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 10/14] WIP: module api: add box_key_def_dump_parts() Alexander Turenko
2020-09-25 22:58 ` Vladislav Shpilevoy
2020-10-09 9:33 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 11/14] WIP: module api: expose box_tuple_validate_key_parts() Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 12/14] WIP: module api: expose box_key_def_merge() Alexander Turenko
2020-09-25 22:58 ` Vladislav Shpilevoy
2020-10-09 1:46 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 13/14] WIP: module api: expose box_tuple_extract_key_ex() Alexander Turenko
2020-09-25 22:58 ` Vladislav Shpilevoy
2020-10-09 1:14 ` Alexander Turenko
2020-10-10 1:21 ` Alexander Turenko
2020-09-23 1:14 ` [Tarantool-patches] [PATCH 14/14] WIP: module api: add box_key_def_validate_key() Alexander Turenko
2020-09-25 22:59 ` Vladislav Shpilevoy
2020-10-09 1:22 ` Alexander Turenko
2020-09-23 1:40 ` Alexander Turenko [this message]
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 01/16] collation: allow to find a collation by a name Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 02/16] refactoring: adjust contract of luaT_tuple_new() Alexander Turenko
2020-09-28 21:26 ` Vladislav Shpilevoy
2020-10-05 11:58 ` Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 03/16] module api: get rid of typedef redefinitions Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 04/16] WIP: module api: expose box region Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 05/16] WIP: module api/lua: add luaL_iscdata() function Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 06/16] WIP: module api/lua: expose luaT_tuple_new() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 07/16] WIP: module api/lua: add luaT_tuple_encode() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 08/16] WIP: refactoring: add API_EXPORT to lua/tuple functions Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 09/16] WIP: refactoring: add API_EXPORT to key_def functions Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 10/16] WIP: refactoring: extract key_def module API functions Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 11/16] WIP: module api: add box_key_def_new_ex() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 12/16] WIP: module api: add box_key_def_dump_parts() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 13/16] WIP: module api: expose box_tuple_validate_key_parts() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 14/16] WIP: module api: expose box_key_def_merge() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 15/16] WIP: module api: expose box_tuple_extract_key_ex() Alexander Turenko
2020-09-23 1:40 ` [Tarantool-patches] [PATCH 1.10 16/16] WIP: module api: add box_key_def_validate_key() Alexander Turenko
2020-10-05 7:26 ` [Tarantool-patches] [PATCH 00/14] RFC: module api: extend for external key_def Lua module Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1600824556.git.alexander.turenko@tarantool.org \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1.10 00/16] RFC: module api: extend for external key_def Lua module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox