From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 35EBA430408 for ; Fri, 14 Aug 2020 18:04:53 +0300 (MSK) From: imeevma@tarantool.org Date: Fri, 14 Aug 2020 18:04:52 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v2 00/10] sql: properly check arguments types of built-in functions List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: v.shpilevoy@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org This patch-set makes SQL to use the ApplyType opcode to validate the argument types of built-in functions. https://github.com/tarantool/tarantool/issues/4159 https://github.com/tarantool/tarantool/tree/imeevma/gh-4159-rework-sql-builtins @ChangeLog - Built-in function argument types are now properly checked (gh-4159). Changes in v2: - Changed an approach to check types of STRING/VARBINARY arguments. - Added a new patch that changes signature of trim(). Mergen Imeev (10): sql: do not return UNSIGNED in built-in functions sql: fix functions return types sql: change signature of trim() box: add new options for functions sql: use has_vararg for built-in functions sql: add overloaded versions of the functions sql: move built-in function definitions in _func box: add param_list to 'struct func' sql: check built-in functions argument types sql: refactor sql/func.c src/box/alter.cc | 12 +- src/box/bootstrap.snap | Bin 5976 -> 6446 bytes src/box/func.c | 1 + src/box/func_def.c | 13 + src/box/func_def.h | 20 + src/box/lua/call.c | 2 + src/box/lua/upgrade.lua | 192 ++++ src/box/sql/analyze.c | 6 +- src/box/sql/expr.c | 33 +- src/box/sql/func.c | 879 +++--------------- src/box/sql/parse.y | 35 +- src/box/sql/resolve.c | 2 +- src/box/sql/select.c | 26 + src/box/sql/sqlInt.h | 19 +- src/box/sql/vdbeapi.c | 2 +- src/box/sql/vdbemem.c | 2 +- test/box-py/bootstrap.result | 6 +- test/box/access.result | 2 +- test/box/access.test.lua | 2 +- test/box/access_bin.result | 2 +- test/box/access_bin.test.lua | 2 +- test/box/access_sysview.result | 8 +- test/box/function1.result | 6 +- test/sql-tap/cse.test.lua | 24 +- test/sql-tap/func.test.lua | 46 +- test/sql-tap/orderby1.test.lua | 2 +- test/sql-tap/position.test.lua | 16 +- test/sql-tap/substr.test.lua | 2 +- test/sql/boolean.result | 32 +- test/sql/checks.result | 8 - test/sql/checks.test.lua | 2 - test/sql/collation.result | 8 + test/sql/collation.test.lua | 1 + test/sql/types.result | 1547 +++++++++++++++++++++++++++++++- test/sql/types.test.lua | 264 ++++++ test/wal_off/func_max.result | 8 +- 36 files changed, 2290 insertions(+), 942 deletions(-) -- 2.25.1