From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 064B9469710 for ; Thu, 4 Jun 2020 11:40:38 +0300 (MSK) From: sergeyb@tarantool.org Date: Thu, 4 Jun 2020 11:39:01 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code in src/ and extra/ with luacheck List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, imun@tarantool.org, v.shpilevoy@tarantool.org Cc: alexander.turenko@tarantool.org From: Sergey Bronnikov Sergey Bronnikov (6): Add initial luacheck config build: enable 'make luacheck' target gitlab-ci: enable static analysis with luacheck Fix luacheck warnings in extra/dist/ Fix luacheck warnings in src/lua/ Fix luacheck warnings in src/box/lua/ .gitlab-ci.yml | 11 +++++++ .luacheckrc | 55 +++++++++++++++++++++++++++++++++ .travis.mk | 23 +++++++++++++- CMakeLists.txt | 11 +++++++ extra/dist/tarantoolctl.in | 25 +++++---------- src/box/lua/console.lua | 10 +++--- src/box/lua/feedback_daemon.lua | 2 +- src/box/lua/key_def.lua | 2 +- src/box/lua/load_cfg.lua | 11 +++---- src/box/lua/net_box.lua | 52 ++++++++++++------------------- src/box/lua/schema.lua | 44 +++++++++++++------------- src/box/lua/tuple.lua | 8 ++--- src/box/lua/upgrade.lua | 19 ++++++------ src/lua/argparse.lua | 3 +- src/lua/buffer.lua | 4 +-- src/lua/clock.lua | 2 +- src/lua/crypto.lua | 4 +-- src/lua/csv.lua | 5 ++- src/lua/digest.lua | 2 +- src/lua/env.lua | 2 +- src/lua/fiber.lua | 4 +-- src/lua/fio.lua | 30 +++++++++--------- src/lua/help.lua | 7 ++--- src/lua/httpc.lua | 3 -- src/lua/init.lua | 4 +-- src/lua/msgpackffi.lua | 22 ++++++------- src/lua/socket.lua | 16 +++++----- src/lua/string.lua | 1 - src/lua/swim.lua | 2 +- src/lua/tap.lua | 4 --- src/lua/trigger.lua | 3 -- 31 files changed, 220 insertions(+), 171 deletions(-) create mode 100644 .luacheckrc -- 2.23.0