From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B6056469710 for ; Wed, 13 May 2020 01:18:33 +0300 (MSK) From: Alexander Turenko Date: Wed, 13 May 2020 01:18:02 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org This patchset provides several fixes for box.execute() and box.cfg() functions when they are called under various circumstances: when a function is saved before box loading and called after it, when a function is called during box loading. Existence of this patchset does not mean that we'll not implement https://github.com/tarantool/tarantool/issues/4726: I don't know whether we will do or will not, but I intend to fix bugs in the existing code. https://github.com/tarantool/tarantool/issues/4231 Totktonada/gh-4231-box-execute-idempotence My review is not more sufficient, because I became co-author of the patchset. Igor, can you, please, review it and pass to a second reviewer (I suggest Vlad)? Alexander Turenko (1): box: always wait box loading in box.execute() Maria (2): box: check whether box is loaded in box.execute() box: always reconfigure box at non-first box.cfg() src/box/lua/load_cfg.lua | 97 +++++++++++++++++-- .../gh-4231-box-cfg-idempotence.test.lua | 34 +++++++ .../gh-4231-box-execute-idempotence.test.lua | 37 +++++++ .../gh-4231-box-execute-locking.test.lua | 69 +++++++++++++ test/box-tap/suite.cfg | 6 ++ test/box-tap/suite.ini | 1 + 6 files changed, 237 insertions(+), 7 deletions(-) create mode 100755 test/box-tap/gh-4231-box-cfg-idempotence.test.lua create mode 100755 test/box-tap/gh-4231-box-execute-idempotence.test.lua create mode 100755 test/box-tap/gh-4231-box-execute-locking.test.lua create mode 100644 test/box-tap/suite.cfg -- 2.25.0