From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 98FD74696C3 for ; Wed, 8 Apr 2020 18:43:17 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id m19so3454340lfq.13 for ; Wed, 08 Apr 2020 08:43:17 -0700 (PDT) From: Sergey Bronnikov Date: Wed, 8 Apr 2020 18:42:58 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v2 0/6] Add static analysis with luacheck List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org Cc: o.piskunov@tarantool.org From: Sergey Bronnikov GitHub branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4681-fix-luacheck-warnings Closes: #4681 Sergey Bronnikov (6): Fix luacheck warnings in src/lua/ Fix luacheck warnings in test/ Fix luacheck warnings in src/box/lua/ Fix luacheck warnings in extra/dist/tarantoolctl.in Add luacheck config gitlab-ci: enable static analysis with luacheck .gitlab-ci.yml | 9 + .luacheckrc | 162 ++++++++++++++++++ .travis.mk | 12 +- extra/dist/tarantoolctl.in | 20 +-- src/box/lua/upgrade.lua | 12 +- src/lua/argparse.lua | 6 +- src/lua/buffer.lua | 4 +- src/lua/clock.lua | 2 +- src/lua/crypto.lua | 4 +- src/lua/csv.lua | 5 +- src/lua/digest.lua | 2 +- src/lua/env.lua | 2 +- src/lua/fio.lua | 25 +-- src/lua/httpc.lua | 3 - src/lua/init.lua | 7 +- src/lua/msgpackffi.lua | 16 +- src/lua/socket.lua | 65 ++++--- src/lua/string.lua | 1 - src/lua/swim.lua | 16 +- src/lua/tap.lua | 75 ++++---- src/lua/trigger.lua | 3 - test/app-tap/console.test.lua | 4 - test/app-tap/csv.test.lua | 28 +-- test/box-py/box.lua | 2 +- test/box-tap/gc.test.lua | 4 +- test/box/box.lua | 2 +- test/box/hash_multipart.result | 2 +- test/box/hash_multipart.test.lua | 2 +- test/box/iproto_stress.result | 8 +- test/box/iproto_stress.test.lua | 4 +- test/box/lua/cfg_bad_vinyl_dir.lua | 2 +- test/box/lua/cfg_rtree.lua | 2 +- test/box/lua/cfg_test1.lua | 2 +- test/box/lua/cfg_test2.lua | 2 +- test/box/lua/cfg_test3.lua | 2 +- test/box/lua/cfg_test4.lua | 2 +- test/box/lua/cfg_test5.lua | 4 +- test/box/lua/cfg_test6.lua | 2 +- test/box/lua/utils.lua | 3 +- test/box/on_schema_init.lua | 2 +- test/box/proxy.lua | 2 +- test/box/tiny.lua | 2 +- test/box/tree_pk.result | 6 +- test/box/tree_pk.test.lua | 6 +- test/engine/tree_min_max_count.result | 2 +- test/engine/tree_min_max_count.test.lua | 2 +- test/replication-py/master.lua | 2 +- test/replication-py/panic.lua | 2 +- test/replication/master.lua | 2 +- test/replication/replicaset_ro_mostly.result | 2 +- .../replication/replicaset_ro_mostly.test.lua | 2 +- test/sql-tap/analyze3.test.lua | 6 +- test/sql-tap/analyze9.test.lua | 16 +- .../gh-4077-iproto-execute-no-bind.test.lua | 7 +- test/sql-tap/index1.test.lua | 1 - test/sql-tap/join3.test.lua | 2 +- test/sql-tap/select9.test.lua | 10 +- test/sql-tap/tkt-fa7bf5ec.test.lua | 6 +- test/sql-tap/where2.test.lua | 2 +- test/sql/lua/sql_tokenizer.lua | 2 +- test/sql/savepoints.result | 6 +- test/sql/savepoints.test.lua | 6 +- test/sql/triggers.result | 2 +- test/sql/triggers.test.lua | 2 +- test/vinyl/large.lua | 4 +- test/vinyl/stat.result | 33 ++-- test/vinyl/stat.test.lua | 22 +-- test/vinyl/txn_proxy.lua | 6 +- test/vinyl/vinyl.lua | 2 +- test/wal_off/rtree_benchmark.result | 2 +- test/wal_off/rtree_benchmark.test.lua | 2 +- test/xlog-py/box.lua | 2 +- test/xlog/big_tx.result | 2 +- test/xlog/big_tx.test.lua | 2 +- test/xlog/checkpoint_daemon.result | 4 +- test/xlog/checkpoint_daemon.test.lua | 4 +- test/xlog/panic.lua | 2 +- test/xlog/panic_on_wal_error.result | 2 +- test/xlog/panic_on_wal_error.test.lua | 2 +- test/xlog/reader.result | 2 +- test/xlog/reader.test.lua | 2 +- test/xlog/snap_io_rate.test.lua | 2 +- test/xlog/transaction.result | 18 +- test/xlog/transaction.test.lua | 18 +- test/xlog/xlog.lua | 2 +- 85 files changed, 463 insertions(+), 300 deletions(-) create mode 100644 .luacheckrc -- 2.23.0