From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B242046970E for ; Fri, 10 Jan 2020 10:28:27 +0300 (MSK) Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1ipoiZ-0002aV-6m for tarantool-patches@dev.tarantool.org; Fri, 10 Jan 2020 10:28:27 +0300 From: Chris Sosnin Date: Fri, 10 Jan 2020 10:28:24 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/2] tuple: fixes for update() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org As Nikita suggested, I split the initial patch into the following two. It already has LGTM from Vlad. branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-3884-update-error issue: https://github.com/tarantool/tarantool/issues/3884 Chris Sosnin (2): tuple: fix non-informative update() error message tuple: add argument length check for update() src/box/errcode.h | 2 +- src/box/xrow_update.c | 4 +-- src/box/xrow_update_field.c | 25 +++++++++++++------ src/box/xrow_update_field.h | 3 ++- ...1-access-settings-from-any-frontend.result | 9 ++++--- test/box/update.result | 18 +++++++++++-- test/box/update.test.lua | 3 +++ test/engine/upsert.result | 13 ++++++---- test/vinyl/gh.result | 3 ++- 9 files changed, 57 insertions(+), 23 deletions(-) -- 2.21.0 (Apple Git-122.2)