From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A5E5C20EE5 for ; Tue, 10 Sep 2019 16:21:08 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DbmFWuxdlCcX for ; Tue, 10 Sep 2019 16:21:08 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 65A1C206AF for ; Tue, 10 Sep 2019 16:21:06 -0400 (EDT) From: Vladislav Shpilevoy Subject: [tarantool-patches] [PATCH v2 0/4] Serializer bugs Date: Tue, 10 Sep 2019 22:24:45 +0200 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org The patchset fixes several problems about JSON and msgpack serializers. 1) msgpackffi didn't use msgpack serializer options; 2) tuple serializer either; 3) update of a serializer option was not reflected in its Lua representation; 4) during serialization too nested tables are silently cropped and there was no way to prevent it. Also it was discovered, that msgpackffi does not care *all* options. Not only about max_depth. I am not sure if it is worth fixing here (or at all) though. Changes in v2: - Renames; - Default value a flag for whether we need to raise an error on a too nested msgpack (was crop, now error). Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4434-box-lua-msgpack-cfg Issue: https://github.com/tarantool/tarantool/issues/4434 Vladislav Shpilevoy (4): app: serializers update now is reflected in Lua msgpack: make msgpackffi use encode_max_depth option tuple: use global msgpack serializer in Lua tuple app: allow to raise an error on too nested tables src/box/lua/tuple.c | 33 +++++++++++++----- src/lua/msgpack.c | 4 +++ src/lua/msgpackffi.lua | 6 ++-- src/lua/utils.c | 47 +++++++++++++++---------- src/lua/utils.h | 32 +++++++++++++++++ test/app-tap/json.test.lua | 3 +- test/app-tap/lua/serializer_test.lua | 31 +++++++++++++++++ test/app-tap/msgpack.test.lua | 3 +- test/app-tap/msgpackffi.test.lua | 31 ++++++++++++++++- test/box/tuple.result | 52 ++++++++++++++++++++++++++++ test/box/tuple.test.lua | 23 ++++++++++++ test/unit/luaT_tuple_new.c | 2 +- third_party/lua-cjson/lua_cjson.c | 10 ++++-- 13 files changed, 243 insertions(+), 34 deletions(-) -- 2.20.1 (Apple Git-117)