From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 12B2E289AD for ; Mon, 2 Sep 2019 10:51:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jZMiWRlVTmVB for ; Mon, 2 Sep 2019 10:51:20 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B0B892899E for ; Mon, 2 Sep 2019 10:51:20 -0400 (EDT) From: Kirill Shcherbatov Subject: [tarantool-patches] [PATCH v3 0/6] box: stacked diagnostics area in fiber Date: Mon, 2 Sep 2019 17:51:08 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, georgy@tarantool.org Cc: alexander.turenko@tarantool.org, kostja@tarantool.org, Kirill Shcherbatov Support stacked diagnostics for Tarantool allows to accumulate all occurred errors during processing a request. This allows to better understand what has happened and handle errors correspondingly. This patch introduces core methods diag_add(), diag_svp(), diag_rollback_to_svp() that allows you to produce a better diagnostics information for a user. There is an other new Lua endpoint box.error.prev() that allows you to get a reason for a given error object. Changes in v3: - fixed Kostya's comments - implemented iproto support for stacked diagnostics Changes in v2: - new API - user shouldn't have an ability to modify an existent error object that he didn't constructed. - a new detailed unit-test that performs a good coverage for many complicated reference-counting scenarios. Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-1148-stacked-errors Issue: https://github.com/tarantool/tarantool/issues/1148 Kirill Shcherbatov (6): box: rfc for stacked diagnostic area in Tarantool box: rename diag_add_error to diag_set_error box: introduce stacked diagnostic area box: extend box.error.new({}) API iproto: refactor error encoding with mpstream iproto: support stacked diagnostics for errors src/box/error.h | 5 +- src/box/iproto_constants.h | 1 + src/lib/core/diag.h | 84 +++++++++++- src/lib/core/exception.h | 2 +- src/lua/error.h | 3 + src/box/key_list.c | 16 +-- src/box/lua/call.c | 6 +- src/box/sql/vdbe.c | 2 +- src/box/vy_scheduler.c | 6 +- src/box/xrow.c | 198 +++++++++++++++++++++++----- src/lib/core/diag.c | 1 + src/lua/error.c | 2 +- src/lua/utils.c | 2 +- test/app-tap/module_api.c | 3 +- test/box/function1.c | 29 ++-- test/box/reload1.c | 20 +-- test/box/reload2.c | 9 +- test/box/tuple_bench.c | 10 +- doc/rfc/1148-stacked-diagnostics.md | 180 +++++++++++++++++++++++++ src/box/applier.cc | 2 +- src/box/error.cc | 7 +- src/box/lua/error.cc | 35 ++++- src/box/lua/net_box.lua | 24 +++- src/box/relay.cc | 4 +- src/lib/core/exception.cc | 2 +- src/lua/error.lua | 12 ++ test/app/fiber.result | 7 +- test/box-py/iproto.result | 6 +- test/box-py/iproto.test.py | 6 +- test/box/misc.result | 159 +++++++++++++++++++++- test/box/misc.test.lua | 49 +++++++ test/engine/func_index.result | 52 ++++++-- test/engine/func_index.test.lua | 7 + test/unit/CMakeLists.txt | 2 +- test/unit/fiber.cc | 157 ++++++++++++++++++++++ test/unit/fiber.result | 60 +++++++++ 36 files changed, 1045 insertions(+), 125 deletions(-) create mode 100644 doc/rfc/1148-stacked-diagnostics.md -- 2.22.1