From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2609C24EA4 for ; Mon, 29 Jul 2019 19:34:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9HoS8LWe9ynx for ; Mon, 29 Jul 2019 19:34:17 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 631E224E45 for ; Mon, 29 Jul 2019 19:34:16 -0400 (EDT) From: Nikita Pettik Subject: [tarantool-patches] [PATCH 0/2] Fix type aliases in SQL Date: Tue, 30 Jul 2019 02:34:09 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: kostja@tarantool.org, Nikita Pettik Branch: https://github.com/tarantool/tarantool/tree/np/sql-type-aliases Justification is described in commit messages, but the main point is to make NoSQL type system be consistent with SQL one at least in types naming. The only concern I've noticed: CAST to NUMBER always results in coversion of integer or string literal to floating point value. Meanwhile, number can hold integer values. So the question is should CAST("integer_literal" AS NUMBER) return floating point, or just be no-op in this case...? Nikita Pettik (2): sql: add STRING alias to TEXT type sql: rename REAL/FLOAT/DOUBLE types to NUMBER extra/mkkeywordhash.c | 8 +- src/box/lua/lua_sql.c | 4 +- src/box/sql/parse.y | 3 +- test/sql-tap/analyze5.test.lua | 2 +- test/sql-tap/analyzeF.test.lua | 2 +- test/sql-tap/atof1.test.lua | 2 +- test/sql-tap/autoinc.test.lua | 4 +- test/sql-tap/boundary3.test.lua | 772 +++++++++++++++---------------- test/sql-tap/cast.test.lua | 76 +-- test/sql-tap/check.test.lua | 4 +- test/sql-tap/default.test.lua | 4 +- test/sql-tap/e_select1.test.lua | 18 +- test/sql-tap/func.test.lua | 2 +- test/sql-tap/in1.test.lua | 2 +- test/sql-tap/in3.test.lua | 4 +- test/sql-tap/in4.test.lua | 2 +- test/sql-tap/index1.test.lua | 8 +- test/sql-tap/insert3.test.lua | 2 +- test/sql-tap/keyword1.test.lua | 3 +- test/sql-tap/numcast.test.lua | 2 +- test/sql-tap/pragma.test.lua | 2 +- test/sql-tap/select3.test.lua | 8 +- test/sql-tap/select4.test.lua | 2 +- test/sql-tap/select7.test.lua | 4 +- test/sql-tap/sort.test.lua | 4 +- test/sql-tap/table.test.lua | 2 +- test/sql-tap/tkt-3998683a16.test.lua | 2 +- test/sql-tap/tkt-91e2e8ba6f.test.lua | 2 +- test/sql-tap/tkt-9a8b09f8e6.test.lua | 4 +- test/sql-tap/tkt1444.test.lua | 2 +- test/sql-tap/tkt2192.test.lua | 2 +- test/sql-tap/transitive1.test.lua | 2 +- test/sql-tap/trigger5.test.lua | 2 +- test/sql-tap/types.test.lua | 2 +- test/sql-tap/where7.test.lua | 4 +- test/sql-tap/whereA.test.lua | 2 +- test/sql-tap/whereB.test.lua | 8 +- test/sql/bind.result | 2 +- test/sql/bind.test.lua | 2 +- test/sql/checks.result | 4 +- test/sql/checks.test.lua | 4 +- test/sql/drop-index.result | 2 +- test/sql/drop-index.test.lua | 2 +- test/sql/errinj.result | 4 +- test/sql/errinj.test.lua | 4 +- test/sql/gh-2929-primary-key.result | 6 +- test/sql/gh-2929-primary-key.test.lua | 6 +- test/sql/gh2251-multiple-update.result | 2 +- test/sql/gh2251-multiple-update.test.lua | 2 +- test/sql/integer-overflow.result | 2 +- test/sql/integer-overflow.test.lua | 2 +- test/sql/iproto.result | 2 +- test/sql/iproto.test.lua | 2 +- test/sql/persistency.result | 2 +- test/sql/persistency.test.lua | 2 +- test/sql/transition.result | 2 +- test/sql/transition.test.lua | 2 +- test/sql/triggers.result | 4 +- test/sql/triggers.test.lua | 4 +- test/sql/types.result | 21 +- test/sql/types.test.lua | 12 +- 61 files changed, 548 insertions(+), 527 deletions(-) -- 2.15.1