From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 90E0E210DB for ; Thu, 4 Jul 2019 07:42:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h86GssW7Yiis for ; Thu, 4 Jul 2019 07:42:09 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 36B8F20E26 for ; Thu, 4 Jul 2019 07:42:09 -0400 (EDT) From: imeevma@tarantool.org Subject: [tarantool-patches] [PATCH v2 0/3] sql: do not show IDs generated by trigger Date: Thu, 4 Jul 2019 14:42:07 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: korablev@tarantool.org Cc: tarantool-patches@freelists.org Currently, if an INSERT was executed by a trigger during the execution of a statement, if there were any generated identifiers, they can be displayed as a result of the statement. This is incorrect, since we are not able to divide the IDs obtained into those that belong to the table mentioned in the statement and those that do not belong to this table. https://github.com/tarantool/tarantool/issues/4188 https://github.com/tarantool/tarantool/tree/imeevma/gh-4188-remove-additonal-generated-ids Changes in v2: 1) Patch was divided into 3 new patches. Mergen Imeev (3): sql: remove unnecessary AUTOINCREMENT ID generation sql: do not show IDs generated by trigger sql: remove VDBE from TXN src/box/errcode.h | 1 + src/box/sequence.c | 22 +++++++++---- src/box/sequence.h | 13 ++++++-- src/box/sql/insert.c | 15 ++++++--- src/box/sql/parse.y | 4 +-- src/box/sql/sqlInt.h | 2 +- src/box/sql/trigger.c | 12 +++---- src/box/sql/vdbe.c | 25 ++++++++------- src/box/sql/vdbe.h | 3 +- src/box/sql/vdbeInt.h | 2 +- src/box/sql/vdbeaux.c | 10 +++--- src/box/txn.h | 17 ---------- test/box/misc.result | 1 + test/sql/gh-2981-check-autoinc.result | 32 ++++++++++++++++++ test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++- test/sql/iproto.result | 2 -- test/sql/triggers.result | 57 +++++++++++++++++++++++++++++++++ test/sql/triggers.test.lua | 14 ++++++++ 18 files changed, 177 insertions(+), 66 deletions(-) -- 2.7.4