From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 01A3531ACF for ; Tue, 25 Jun 2019 09:38:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s0tqNgt4syEW for ; Tue, 25 Jun 2019 09:38:30 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 41A9330CEB for ; Tue, 25 Jun 2019 09:38:30 -0400 (EDT) From: Roman Khabibov Subject: [tarantool-patches] [PATCH v2 0/2] take getaddrinfo() errors into account Date: Tue, 25 Jun 2019 16:38:26 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org Before this patch, branch when getaddrinfo() returns error codes couldn't be reached on Mac OS, because they are greater than 0 on Mac OS (checking for errors was rc < 0). Roman Khabibov (2): lua: return getaddrinfo() errors say: take getaddrinfo() errors into account src/box/lua/net_box.lua | 7 +++++-- src/lib/core/coio_task.c | 2 +- src/lib/core/say.c | 3 ++- src/lua/socket.c | 17 ++++++++++++++++- src/lua/socket.lua | 37 +++++++++++++++++++++++-------------- test/app/socket.result | 21 ++++++++++++++++++++- test/app/socket.test.lua | 10 ++++++++++ test/box-tap/cfg.test.lua | 19 ++++++++++++++++++- test/box/net.box.result | 11 +++++++++++ test/box/net.box.test.lua | 8 ++++++++ test/unit/coio.cc | 7 ++++++- test/unit/coio.result | 4 +++- 12 files changed, 123 insertions(+), 23 deletions(-) -- Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4138-getaddrinfo Issue: https://github.com/tarantool/tarantool/issues/4138 2.20.1 (Apple Git-117)