From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7F12927813 for ; Mon, 11 Mar 2019 14:10:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KeUpUthrTNyQ for ; Mon, 11 Mar 2019 14:10:30 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B76F226C05 for ; Mon, 11 Mar 2019 14:10:29 -0400 (EDT) From: Nikita Pettik Subject: [tarantool-patches] [PATCH 0/2] SQL types fixes Date: Mon, 11 Mar 2019 21:10:24 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Branch: https://github.com/tarantool/tarantool/tree/np/sql-types-fixes No related issue First patch fixes names send as column meta-information. After BLOB type was substituted with SCALAR, it can be confusing saying that column has type BLOB. Moreover, other string represantations have been replaced with exact names of NoSQL types (i.e. STRING, NUMER etc). Second patch fixes wrong type calculation for returning value for function: it takes place during name resolution, and its second promotion during byte-code generation is redundant (and in some cases is wrong). Nikita Pettik (2): sql: make type in column-meta be consistent with NoSQL names sql: don't change type of function's retval after codegen src/box/sql/expr.c | 11 --- src/box/sql/select.c | 31 +------- test/sql/errinj.result | 2 +- test/sql/gh-2362-select-access-rights.result | 4 +- test/sql/iproto.result | 109 ++++++++++++++++++--------- test/sql/iproto.test.lua | 15 ++++ 6 files changed, 97 insertions(+), 75 deletions(-) -- 2.15.1