From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4CBA528585 for ; Fri, 15 Feb 2019 12:14:51 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RQG68at7EtYR for ; Fri, 15 Feb 2019 12:14:51 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F03D02728F for ; Fri, 15 Feb 2019 12:14:50 -0500 (EST) From: imeevma@tarantool.org Subject: [tarantool-patches] [PATCH v2 0/2] sql: use diag_set() for errors in SQL Date: Fri, 15 Feb 2019 20:14:48 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: korablev@tarantool.org Cc: tarantool-patches@freelists.org, kostja@tarantool.org The goal of this patch-set is to rework all SQL errors and make Tarantool ones from them. Difference from v1: Added patch that removes field suppressErr. https://github.com/tarantool/tarantool/issues/3965 https://github.com/tarantool/tarantool/tree/imeevma/gh-3965-use-diag_set-to-describe-error Previous versions: https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-rework-no-such-object-and-object-exists-errors Mergen Imeev (2): sql: remove field suppressErr from struct sql sql: rework "no such object" and "object exists" errors src/box/errcode.h | 7 +-- src/box/lua/schema.lua | 4 +- src/box/space.h | 2 +- src/box/sql/build.c | 37 +++++++------- src/box/sql/delete.c | 3 +- src/box/sql/expr.c | 5 +- src/box/sql/pragma.c | 3 +- src/box/sql/resolve.c | 25 ++++----- src/box/sql/select.c | 12 +++-- src/box/sql/sqlInt.h | 9 +++- src/box/sql/update.c | 5 +- src/box/sql/util.c | 19 ++++--- test/box/misc.result | 5 +- test/sql-tap/alter.test.lua | 2 +- test/sql-tap/analyzeF.test.lua | 4 +- test/sql-tap/check.test.lua | 4 +- test/sql-tap/e_select1.test.lua | 26 ++++------ test/sql-tap/fkey2.test.lua | 2 +- test/sql-tap/func.test.lua | 2 +- test/sql-tap/gh-2367-pragma.test.lua | 2 +- test/sql-tap/gh-2996-indexed-by.test.lua | 12 ++--- test/sql-tap/gh2130-index-refer-table.test.lua | 4 +- test/sql-tap/identifier_case.test.lua | 2 +- test/sql-tap/in1.test.lua | 2 +- test/sql-tap/in3.test.lua | 2 +- test/sql-tap/index-info.test.lua | 2 +- test/sql-tap/index1.test.lua | 6 +-- test/sql-tap/insert1.test.lua | 6 +-- test/sql-tap/insert3.test.lua | 4 +- test/sql-tap/join.test.lua | 2 +- test/sql-tap/limit.test.lua | 4 +- test/sql-tap/lua-tables.test.lua | 2 +- test/sql-tap/lua_sql.test.lua | 2 +- test/sql-tap/misc1.test.lua | 4 +- test/sql-tap/select1.test.lua | 16 +++--- test/sql-tap/select4.test.lua | 10 ++-- test/sql-tap/select5.test.lua | 8 +-- test/sql-tap/selectB.test.lua | 52 ++++++------------- test/sql-tap/table.test.lua | 16 +++--- test/sql-tap/tkt-4ef7e3cfca.test.lua | 2 +- test/sql-tap/tkt2822.test.lua | 70 +------------------------- test/sql-tap/tkt3346.test.lua | 2 +- test/sql-tap/tkt3442.test.lua | 2 +- test/sql-tap/triggerB.test.lua | 6 +-- test/sql-tap/update.test.lua | 16 +++--- test/sql-tap/view.test.lua | 24 ++------- test/sql-tap/with1.test.lua | 13 +---- test/sql-tap/with2.test.lua | 4 +- test/sql/checks.result | 4 +- test/sql/delete.result | 4 +- test/sql/drop-table.result | 4 +- test/sql/gh-2929-primary-key.result | 2 +- test/sql/gh-3613-idx-alter-update.result | 2 +- test/sql/gh-3888-values-blob-assert.result | 4 +- test/sql/icu-upper-lower.result | 2 +- test/sql/iproto.result | 2 +- 56 files changed, 197 insertions(+), 300 deletions(-) -- 2.7.4