From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0F4FB26516 for ; Wed, 13 Feb 2019 08:43:09 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J4um6VOB4ceP for ; Wed, 13 Feb 2019 08:43:08 -0500 (EST) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 637BC2650C for ; Wed, 13 Feb 2019 08:43:08 -0500 (EST) From: Stanislav Zudin Subject: [tarantool-patches] [PATCH v5 0/2] Remove useless pragmas Date: Wed, 13 Feb 2019 16:42:47 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, korablev@tarantool.org Cc: Stanislav Zudin The pragmas "busy_timeout", "query_only" and "read_uncommitted" didn't affect anything and were removed. Fixed an error in pragma index_list which caused a segmantation fault. pragma sql_default_engine accepts only strings. Thus pragma sql_default_engine('memtx') is a well-formed command, while pragma sql_default_engine(memtx) or pragma sql_default_engine("memtx") are considered as an ill-formed and raise an error. SQLite's busyHandler functionality and functions sqlite3_sleep(), sqlite3OsSleep() were not used and were removed. Removed unreachable error handling. Issue: https://github.com/tarantool/tarantool/issues/3733 Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3733-obsolete-pragmas Stanislav Zudin (2): sql: remove useless pragmas sql: remove busy handler src/box/sql/main.c | 76 ------------ src/box/sql/os.c | 6 - src/box/sql/os.h | 1 - src/box/sql/os_unix.c | 18 --- src/box/sql/pragma.c | 51 ++++---- src/box/sql/pragma.h | 46 ++----- src/box/sql/sqliteInt.h | 26 ---- src/box/sql/vdbe.c | 1 - test/sql-tap/gh-3733-pragma.test.lua | 177 +++++++++++++++++++++++++++ 9 files changed, 219 insertions(+), 183 deletions(-) create mode 100755 test/sql-tap/gh-3733-pragma.test.lua -- 2.17.1