From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0491626CCE for ; Fri, 8 Feb 2019 07:52:41 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vU9Ru9KChGt7 for ; Fri, 8 Feb 2019 07:52:40 -0500 (EST) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ECA5F26D25 for ; Fri, 8 Feb 2019 07:52:39 -0500 (EST) From: Kirill Shcherbatov Subject: [tarantool-patches] [PATCH v1 0/4] sql: replace 32 bit column mask Date: Fri, 8 Feb 2019 15:52:24 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, v.shpilevoy@tarantool.org Cc: Kirill Shcherbatov Column mask in Tarantool is not just 32 bits greater, but also it is smarter. When a column with number > 63 is added to the mask, the only last bit (64th) is set indicating the overflow. SQLite mask in such a case just resets the whole mask in -1. Reworked sqlite code to use Tarantool mask helpers everywhere. Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3571-sql-column-mask-64 Issue: https://github.com/tarantool/tarantool/issues/3571 Kirill Shcherbatov (4): box: introduce new helpers in column_mask.h sql: use 64b bitmasks instead of 32b where possible sql: got rid of redundant MASKBIT32 definition sql: got rid of redundant bitmask helpers src/box/alter.cc | 10 +--- src/box/column_mask.h | 39 +++++++++++--- src/box/sql/delete.c | 8 ++- src/box/sql/expr.c | 53 ++++++++++--------- src/box/sql/resolve.c | 31 +++-------- src/box/sql/sqliteInt.h | 71 +++++++++++--------------- src/box/sql/trigger.c | 14 ++--- src/box/sql/update.c | 21 ++++---- src/box/sql/vdbeaux.c | 7 ++- src/box/sql/where.c | 110 ++++++++++++++++++---------------------- src/box/sql/whereInt.h | 3 +- 11 files changed, 175 insertions(+), 192 deletions(-) -- 2.20.1