From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 176752727A for ; Thu, 7 Feb 2019 12:25:31 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mmsVaxN8v4Q3 for ; Thu, 7 Feb 2019 12:25:31 -0500 (EST) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 574E927278 for ; Thu, 7 Feb 2019 12:25:30 -0500 (EST) From: Georgy Kirichenko Subject: [tarantool-patches] [PATCH v2 0/2] Do not promote vclocks in case of failure Date: Thu, 7 Feb 2019 20:27:29 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko Promote tx and wal vclock only if corresponding row was successfully written to wal. This prevents tarantool from skipping rows in case of replication errors as well as from making lsn gaps after IO errors. Branch: https://github.com/tarantool/tarantool/tree/g.kirichenko/gh-2283-dont-skip-rows-after-errors Issue: https://github.com/tarantool/tarantool/issues/2283 Changes in v2: - commits 2 and 3 are squashed - test fixed according to review - comment fixed according to review Georgy Kirichenko (2): Do not promote wal vclock for failed writes Promote replicaset.vclock only after wal src/box/applier.cc | 46 +-- src/box/wal.c | 67 ++-- test/box/errinj.result | 59 +++ test/box/errinj.test.lua | 20 ++ test/replication/skip_conflict_row.result | 63 ++++ test/replication/skip_conflict_row.test.lua | 20 ++ test/xlog/errinj.result | 1 - test/xlog/panic_on_lsn_gap.result | 377 -------------------- test/xlog/panic_on_lsn_gap.test.lua | 136 ------- 9 files changed, 210 insertions(+), 579 deletions(-) delete mode 100644 test/xlog/panic_on_lsn_gap.result delete mode 100644 test/xlog/panic_on_lsn_gap.test.lua -- 2.20.1