From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Vladimir Davydov Subject: [PATCH 0/8] Get rid of Vinyl's mem_format_with_colmask Date: Sun, 14 Oct 2018 21:16:44 +0300 Message-Id: To: kostja@tarantool.org Cc: tarantool-patches@freelists.org List-ID: There are two formats for memory statements in Vinyl, vy_lsm::mem_format and vy_lsm::mem_format_with_colmask. The only difference between them is that the latter allows to store column mask inside tuples. It is used to optimize out tautological updates in the write iterator. Turns out that we can easily do without it as this patch set demonstrates. I've always wanted to drop this format because I hate the very idea of tuple_extra (that's why I dropped upsert format a while ago as well). However, the reason why I'm doing this now is that it is the only thing why we need tuple_format_dup. Currently, tuple_format_dup is basically a memcpy, but once JSON indexes are introduced it's going to become much more complex than just that so we'd better drop it now. https://github.com/tarantool/tarantool/commits/dv/vy-zap-format-with-colmask Vladimir Davydov (8): vinyl: move update optimization from write iterator to tx vinyl: factor out common code of UPDATE and UPSERT vinyl: do not use column mask as trigger for turning REPLACE into INSERT vinyl: explicitly pass column mask to vy_tx_set vinyl: explicitly pass column mask to vy_check_is_unique vinyl: zap vy_stmt_column_mask and mem_format_with_colmask tuple: zap tuple_format_dup tuple: zap tuple_extra src/box/blackhole.c | 2 +- src/box/memtx_engine.c | 10 +-- src/box/memtx_space.c | 2 +- src/box/tuple.c | 12 +-- src/box/tuple.h | 30 ++----- src/box/tuple_format.c | 28 +----- src/box/tuple_format.h | 33 +------ src/box/vinyl.c | 179 ++++++++++++++++--------------------- src/box/vy_lsm.c | 30 ++----- src/box/vy_lsm.h | 8 -- src/box/vy_mem.c | 14 +-- src/box/vy_mem.h | 17 ++-- src/box/vy_stmt.c | 28 +++--- src/box/vy_stmt.h | 55 +++--------- src/box/vy_tx.c | 36 ++++---- src/box/vy_tx.h | 11 ++- src/box/vy_write_iterator.c | 47 +++------- src/box/vy_write_iterator.h | 26 +----- test/unit/vy_cache.c | 9 +- test/unit/vy_iterators_helper.c | 36 +++----- test/unit/vy_iterators_helper.h | 19 +--- test/unit/vy_mem.c | 2 +- test/unit/vy_point_lookup.c | 15 ++-- test/unit/vy_write_iterator.c | 105 +--------------------- test/unit/vy_write_iterator.result | 54 +++++------ 25 files changed, 237 insertions(+), 571 deletions(-) -- 2.11.0