From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0FC422928F for ; Fri, 31 Aug 2018 11:45:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E58bohufAobF for ; Fri, 31 Aug 2018 11:45:50 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6823B29170 for ; Fri, 31 Aug 2018 11:45:50 -0400 (EDT) From: Kirill Shcherbatov Subject: [tarantool-patches] [PATCH v1 0/3] sql: dissallow bindings for DDL Date: Fri, 31 Aug 2018 18:45:39 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3653-no-bindings-on-ddl Issue: https://github.com/tarantool/tarantool/issues/3653 Bindings could not be used in stored ACTs because they allocate memory registers and makes assignments on parse sequentially. Original sqlite3 did validations that persistent AST doesn't have auto-assigment Varibles on triggers and checks creation. On DDL integration complete we've get rid this mechanism. Now it should be returned. Also fixed memory leak on error in sql_*_compile functions and double free with sql_check_list_item_init. Kirill Shcherbatov (3): sql: fix sql_check_list_item_init double free sql: fix sql_*_compile functions leak on error sql: dissallow bindings for DDL src/box/space_def.c | 3 ++- src/box/sql.c | 5 ++--- src/box/sql/parse.y | 6 +++++- src/box/sql/prepare.c | 1 - src/box/sql/tokenize.c | 9 ++++----- test/sql-tap/check.test.lua | 4 ++-- test/sql/checks.result | 45 ++++++++++++++++++++++++++++++++++++++++++++- test/sql/checks.test.lua | 18 +++++++++++++++++- 8 files changed, 76 insertions(+), 15 deletions(-) -- 2.7.4